Skip to content
This repository has been archived by the owner on Aug 26, 2021. It is now read-only.

Migrate deployment configuration to use NGINX #306

Open
3 tasks done
azerella opened this issue Nov 8, 2018 · 2 comments
Open
3 tasks done

Migrate deployment configuration to use NGINX #306

azerella opened this issue Nov 8, 2018 · 2 comments
Assignees
Labels
enhancement New feature or request.

Comments

@azerella
Copy link
Contributor

azerella commented Nov 8, 2018

Enhancement

Our current deployment of this site is done with custom Node.js code, a static site such as ours should be an ideal candidate for something like NGINX. Because we are using custom Node.js server code, things like parsing uncommon MIME types such as .webmanifest, instead a 401 status is returned, in our staging configuration. This is no bueno.

@alex-page @sukhrajghuman
I would like to introduce the idea that we are currently handling the site deployment the wrong way. We're deploying a production grade site with simple express code, the site should be deployed as a static bundle with something like nginx or apache. The search functionality should be a seperate deployment that the static site fetches / posts to.

Issues:

  • Site uses older HTTP 1/1 protocol. h2 is the new hotness.

  • No gzip compression is in use, our assets could be way smaller.

  • Separating the deployment and search functionality would reduce the page load time as we'd need to download less assets.

  • I’ve read and understood the Contributing guidelines and have done my best effort to follow them.

  • I’ve read and agree to the Code of Conduct.

  • I’ve searched for any related issues and avoided creating a duplicate issue.

@azerella azerella self-assigned this Nov 8, 2018
@azerella azerella added the 🐛 bug Something isn’t working the way it should. label Nov 8, 2018
@azerella azerella added this to the Sprint 116 milestone Nov 8, 2018
@sukhrajghuman sukhrajghuman modified the milestones: Sprint 116, Sprint 117 Nov 13, 2018
@alex-page
Copy link
Contributor

I will need a bit of a better explanation, the lojk file should be getting read here?

@sukhrajghuman sukhrajghuman modified the milestones: Sprint 117, Sprint 118 Nov 28, 2018
@sukhrajghuman sukhrajghuman modified the milestones: Sprint 118, Sprint 119 Dec 11, 2018
@alex-page
Copy link
Contributor

@adamzerella I am not too concerned about the staging or test instances, is this affecting live as well?

@azerella azerella removed the 🐛 bug Something isn’t working the way it should. label Jan 6, 2019
@azerella azerella changed the title Express server is unable to parse unusual MIME types in staging / test Migrate deployment configuration to use NGINX Jan 6, 2019
@azerella azerella added the enhancement New feature or request. label Jan 6, 2019
@sukhrajghuman sukhrajghuman removed this from the Sprint 119 milestone Jan 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request.
Projects
None yet
Development

No branches or pull requests

3 participants