Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Upgrade preview-link code sample to 3p-resources #186

Merged
merged 21 commits into from
Jan 25, 2024

Conversation

PierrickVoulet
Copy link
Contributor

  • Remove people preview link
  • Add case 3P resource creation from @ menu

Copy link

snippet-bot bot commented Jan 24, 2024

Here is the summary of possible violations 😱

There are 28 possible violations for not having product prefix.

The end of the violation section. All the stuff below is FYI purposes only.


Here is the summary of changes.

You are about to add 28 region tags.
You are about to delete 12 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@PierrickVoulet PierrickVoulet changed the title feat: Upgrade PreviewLink code sample to 3P Resources feat: Upgrade preview-link code sample to 3p-resources Jan 24, 2024
Copy link
Contributor

@vinay-google vinay-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Left few nits

@PierrickVoulet PierrickVoulet merged commit ece111d into main Jan 25, 2024
11 of 16 checks passed
@PierrickVoulet PierrickVoulet deleted the dpp-create-3p-resources-docs branch January 25, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants