Skip to content
This repository has been archived by the owner on Mar 13, 2018. It is now read-only.

As used in Polymer, dirty checking performance needs improvement #68

Open
sorvell opened this issue Aug 13, 2014 · 1 comment
Open

As used in Polymer, dirty checking performance needs improvement #68

sorvell opened this issue Aug 13, 2014 · 1 comment

Comments

@sorvell
Copy link

sorvell commented Aug 13, 2014

This issue is relevant only when Object.observe is unavailable.

The topeka app takes ~12ms to do a no-op dirty check in Safari and ~45ms on an iPad. This was determined by timing Platform.performMicrotaskCheckpoint within Polymer's dirty check interval when the app was idle. This jsperf suggests that dirty checking polymer's observed property getters is particularly slow. A quick test to comment out most of the work done in these getters improved the dirty check time by ~33%. Note also that Topeka has about 1200 observers, as reported by Observer._allObserversCount.

@jmesserly jmesserly added the p1 label Aug 18, 2014
@jmesserly jmesserly assigned jmesserly and unassigned rafaelw Aug 18, 2014
@jmesserly jmesserly removed the p1 label Aug 28, 2014
@jmesserly
Copy link
Contributor

we'll likely file a polymer issue to make sure we don't trigger dirty checking for scroll events

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants