-
Notifications
You must be signed in to change notification settings - Fork 609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
web: flamegraph: show filename in tooltip #655
Comments
Looks like there's options for an HTML-based tooltip in the latest d3-flamegraph: https://github.com/spiermar/d3-flame-graph#tooltip |
The filename isn't passed as JSON to the FlameGraph yet, we'll want to add it to the |
Can't just pass |
@mhansen RE empty filenames: can you try passing |
I'm still wondering if we could put the filename in the tooltip by default, but I could go either way on it (this at least solves my immediate problem of how to demo |
I think we went back and forth on having |
#106 is when we changed this. We could force a different default in the flame graph generation perhaps, though we'll need to make sure this only changes the defaults and choosing a different granularity on the command line is still possible (e.g. |
@mhansen For the blog post, you could simply have the instructions there as "Run pprof with |
I don't think we should flip the defaults. I'm just wondering about maybe
sending the filename and the function name down in the JSON, and making a
richer tooltip that shows the filename+function.
…On Sat, 16 Oct 2021 at 08:28, Alexey Alexandrov ***@***.***> wrote:
#106 <#106> is when we changed this.
We could force a different default in the flame graph generation perhaps,
though we'll need to make sure this only changes the defaults and choosing
a different granularity on the command line is still possible (e.g.
-addresses etc).
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#655 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAZYOLK3DV5CFPZRYJA53TUHCMGFANCNFSM5FECQC5A>
.
|
Forked off from #649 (comment)
What version of pprof are you using?
7fe48b4
What did you do?
Open the flamegraph view in the web browser:
What did you expect to see?
Filename in the tooltip -- in this case I used
-roottag thread
to add synthetic stack frames to the root of the trace, with the Filename = "thread", so help label the node.What did you see instead?
No filename.
Fixing this might require moving to a DOM-element for the tooltip, I'm not sure if browsers natively support multiline tooltips?
The text was updated successfully, but these errors were encountered: