The compiler produce invalid spirv with enabled PhysicalPointerArgsPass. #1418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexDemydenko
force-pushed
the
GFXSW-50817
branch
2 times, most recently
from
ae40adf
to
75101bd
Compare
|
@alan-baker and @rjodinchr, do you any inputs for @AlexDemydenko on this issue/PR? |
|
What kinds of errors? When I run: The resulting binary passes spirv-val. What command line are you using? |
|
This is at least missing a test I would say. |
|
Command line from the clvk driver: Error from spirv-val: |
The tool spirv-val return errors for some spirv binaries.
AlexDemydenko
force-pushed
the
GFXSW-50817
branch
from
75101bd
to
ecf4319
Compare
|
ping |
rjodinchr
reviewed
Nov 22, 2024
| @@ -354,6 +354,11 @@ void ComputeStore(IRBuilder<> &Builder, StoreInst *ST, Value *OrgGEPIdx, | |||
| unsigned DstEleTyBitWidth = SizeInBits(Builder, DstEleTy); | |||
|
|
|||
| Type *OrigSrcTy = SrcTy; | |||
| if (dyn_cast<IntToPtrInst>(Src)) { | |||
There was a problem hiding this comment.
Could you add a comment to explain what is happening here, and why it is needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tool spirv-val return errors for some spirv binaries.
The test list with OpenCL-CTS:
Kernel example:
vector-swizzle.txt