Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow dot in token names #331

Open
JeroenvIS opened this issue Oct 27, 2022 · 0 comments
Open

Allow dot in token names #331

JeroenvIS opened this issue Oct 27, 2022 · 0 comments

Comments

@JeroenvIS
Copy link

A year or two ago, with #208 a change was incorporated to enforce more strict naming rules. We often use FQDNs as tokens, eg for host/network definitions. Since this change that yields a large amount of warnings.

Would it be acceptable to also permit dots in token names? I haven't seen any problems yet when I locally change the token_re in L134 in naming.py, but maybe there's a downside to this that I don't understand yet.

[1]

self.token_re = re.compile(r'(^[-_A-Z0-9]+$)', re.IGNORECASE)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant