Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

token versioning #421

Open
iraj720 opened this issue Nov 23, 2024 · 3 comments
Open

token versioning #421

iraj720 opened this issue Nov 23, 2024 · 3 comments

Comments

@iraj720
Copy link

iraj720 commented Nov 23, 2024

i have added versioning to the library. i think it makes it easier since we are facing with this challenge.

also it doesn't effect other parts of the projects.

here it is : #420

@mfridman
Copy link
Member

Thank you for opening an issue, but this feels a bit specific to your needs or application. I assume you've got all the building blocks from this library to create a little wrapper in your application for handling versioned claims?

@iraj720
Copy link
Author

iraj720 commented Nov 23, 2024

yes i can but i need to rewrite it for all services and i think it might be useful for others also. do you agree with it?

@mfridman
Copy link
Member

We have a finite capacity to integrate additional logic into the core library. If we were to fulfill every feature request we receive, it could lead to considerable bloat within the package, increasing the API surface and harder to maintain.

We're trying to strike a balance to ensure optimal user experience. Let's see if @oxisto has an opinion here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants