-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip admin and change oidc user not found message more readable #21061
Open
stonezdj
wants to merge
1
commit into
goharbor:main
Choose a base branch
from
stonezdj:24oct18_oidc_admin_error
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #21061 +/- ##
===========================================
+ Coverage 45.36% 66.08% +20.71%
===========================================
Files 244 1049 +805
Lines 13333 114661 +101328
Branches 2719 2867 +148
===========================================
+ Hits 6049 75768 +69719
- Misses 6983 34749 +27766
- Partials 301 4144 +3843
Flags with carried forward coverage won't be shown. Click here to find out more.
|
stonezdj
force-pushed
the
24oct18_oidc_admin_error
branch
from
October 18, 2024 09:11
4ba168e
to
06d5924
Compare
5 tasks
+1, this would be very helpful |
+1 |
stonezdj
force-pushed
the
24oct18_oidc_admin_error
branch
2 times, most recently
from
November 19, 2024 04:40
93cfdc4
to
c6ce7bc
Compare
stonezdj
added
target/2.13.0
issues that are targeting v2.13.0
and removed
candidate/2.13.0
labels
Nov 20, 2024
fixes goharbor#21041 Signed-off-by: stonezdj <stone.zhang@broadcom.com>
stonezdj
force-pushed
the
24oct18_oidc_admin_error
branch
from
November 20, 2024 02:56
c6ce7bc
to
58b9680
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #21041
verified in local env
Thank you for contributing to Harbor!
Comprehensive Summary of your change
Issue being fixed
Fixes #(issue)
Please indicate you've done the following: