Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Correcting time unit for logs of added http-service #1214

Open
wants to merge 5 commits into
base: development
Choose a base branch
from

Conversation

coolwednesday
Copy link
Contributor

@coolwednesday coolwednesday commented Nov 18, 2024

Pull Request Template

Description:

  • Closes BUG: Change Time Unit from Milliseconds to Microseconds #1197
  • Previously, all the duration to be displayed in the logs, were calculated in milliseconds but while printing it through prettyprint, we use to display as microseconds, which is wrong. Hence corrected the calculations to be done in microseconds..

Checklist:

  • I have formatted my code using goimport and golangci-lint.
  • All new code is covered by unit tests.
  • This PR does not decrease the overall code coverage.
  • I have reviewed the code comments and documentation for clarity.

Thank you for your contribution!

@ccoVeille
Copy link
Contributor

Please update the PR description

-we use to display as microseconds, which is wrong. Hence corrected the calculations to be done in Microseconds.
+we use to display as milliseconds, which is wrong. Hence corrected the calculations to be done in microseconds.

@coolwednesday
Copy link
Contributor Author

coolwednesday commented Nov 18, 2024

Please update the PR description

-we use to display as microseconds, which is wrong. Hence corrected the calculations to be done in Microseconds.
+we use to display as milliseconds, which is wrong. Hence corrected the calculations to be done in microseconds.

@ccoVeille , I mean what I wrote. The log displays 8 microseconds where in actually gofr calculates it as 8 milliseconds. So we are correcting that, to corrrectly show ....8,000 µs.

@ccoVeille
Copy link
Contributor

Please update the PR description

-we use to display as microseconds, which is wrong. Hence corrected the calculations to be done in Microseconds.
+we use to display as milliseconds, which is wrong. Hence corrected the calculations to be done in microseconds.

@ccoVeille , I mean what I wrote. The log displays 8 microseconds where in actually gofr calculates it as 8 milliseconds. So we are correcting that, to corrrectly show ....8,000 µs.

OK, so I think I'm lost.

Let's reboot.

Your text says:

we use to display as microseconds, which is wrong. Hence corrected the calculations to be done in microseconds.

So it means

  • it was in microseconds
  • we fixed to use microseconds

The code :

  • was calling milliseconds
  • is updated to call microseconds

So for me, there is a problem with the text. The code is fine

Copy link
Member

@aryanmehrotra aryanmehrotra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing changes for transaction in SQL DB and openTSDB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Change Time Unit from Milliseconds to Microseconds
4 participants