Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Missing Connection Successful Logs #1206

Open
wants to merge 32 commits into
base: development
Choose a base branch
from
Open

Fix: Missing Connection Successful Logs #1206

wants to merge 32 commits into from

Conversation

coolwednesday
Copy link
Contributor

@coolwednesday coolwednesday commented Nov 15, 2024 •
edited
Loading

Pull Request Template

Description:

Checklist:

  • I have formatted my code using goimport and golangci-lint.
  • All new code is covered by unit tests.
  • This PR does not decrease the overall code coverage.
  • I have reviewed the code comments and documentation for clarity.

Thank you for your contribution!

@coolwednesday coolwednesday changed the title Missing logs Fix: Missing Connection Successful Logs Nov 15, 2024
@ccoVeille
Copy link
Contributor

Why closing?

@ccoVeille
Copy link
Contributor

Is it because this one superseded it?

#1205

@coolwednesday
Copy link
Contributor Author

Why closing?

There are continuous build fails. I will address that and then reopen, this PR.

@coolwednesday coolwednesday reopened this Nov 17, 2024
Umang01-hash
Umang01-hash requested changes Nov 18, 2024
View reviewed changes
pkg/gofr/datasource/file/s3/fs.go Outdated Show resolved Hide resolved
pkg/gofr/datasource/file/s3/fs.go Outdated Show resolved Hide resolved
pkg/gofr/datasource/file/ftp/fs.go Outdated Show resolved Hide resolved
pkg/gofr/datasource/file/ftp/fs.go Outdated Show resolved Hide resolved
ccoVeille
ccoVeille reviewed Nov 18, 2024
View reviewed changes
pkg/gofr/datasource/file/mock_interface.go Outdated Show resolved Hide resolved
pkg/gofr/datasource/mongo/mongo.go Outdated Show resolved Hide resolved
pkg/gofr/datasource/pubsub/eventhub/eventhub.go Outdated Show resolved Hide resolved
pkg/gofr/datasource/pubsub/eventhub/eventhub.go Outdated Show resolved Hide resolved
pkg/gofr/datasource/pubsub/kafka/kafka.go Outdated Show resolved Hide resolved
Umang01-hash
Umang01-hash previously approved these changes Nov 18, 2024
View reviewed changes
dependabot bot and others added 9 commits November 20, 2024 10:56
ccoVeille
ccoVeille reviewed Nov 20, 2024
View reviewed changes
pkg/gofr/datasource/cassandra/cassandra.go Outdated Show resolved Hide resolved
pkg/gofr/datasource/cassandra/cassandra_test.go Outdated Show resolved Hide resolved
pkg/gofr/datasource/clickhouse/clickhouse.go Outdated Show resolved Hide resolved
pkg/gofr/datasource/file/ftp/mock_interface.go Outdated Show resolved Hide resolved
pkg/gofr/datasource/mongo/mongo.go Outdated Show resolved Hide resolved
pkg/gofr/datasource/mongo/mongo.go Outdated Show resolved Hide resolved
Umang01-hash
Umang01-hash requested changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@Umang01-hash Umang01-hash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think to maintain code uniformity isn't it better to introduce Debugf in interface wherever needed instead of using Debug(fmt.Sprintf()) ?

pkg/gofr/datasource/pubsub/nats/client.go Show resolved Hide resolved
Umang01-hash
Umang01-hash previously approved these changes Nov 21, 2024
View reviewed changes
@ccoVeille
Copy link
Contributor

I think to maintain code uniformity isn't it better to introduce Debugf in interface wherever needed instead of using Debug(fmt.Sprintf()) ?

I beg you to introduce Debugf, using Debug(fmt.Sprintf()), is a clear stop for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccoVeille ccoVeille ccoVeille left review comments

@vipul-rawat vipul-rawat vipul-rawat approved these changes

@Umang01-hash Umang01-hash Umang01-hash left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing Successful Connection Logs At Info Level
4 participants
@coolwednesday @ccoVeille @vipul-rawat @Umang01-hash