Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.3] Resource::get_rid is not exposed as virtual #1640

Open
mohsenph69 opened this issue Nov 13, 2024 · 3 comments
Open

[4.3] Resource::get_rid is not exposed as virtual #1640

mohsenph69 opened this issue Nov 13, 2024 · 3 comments
Labels
bug This has been identified as a bug
Milestone

Comments

@mohsenph69
Copy link

Godot version

4.3

godot-cpp version

4.3

System information

Linux manjaro

Issue description

Resource::get_rid is not exposed as virtual, and that make it impossible to create a custom mesh!

Steps to reproduce

NOTHING

Minimal reproduction project

NOTHING

@dsnopek
Copy link
Collaborator

dsnopek commented Nov 13, 2024

The virtual function is Resource::_get_rid() (with an underscore)

@mohsenph69
Copy link
Author

The virtual function is Resource::_get_rid() (with an underscore)

Yeah with an underscore, it exist in GDScript but not GDExtension!

@dsnopek
Copy link
Collaborator

dsnopek commented Nov 13, 2024

Ah, I see, it's only in Godot master not 4.3. This was fixed in godotengine/godot#84944

It would be theoretically possible to implement for 4.3, using GDExtensionClassCreationInfo::get_rid_func, but would require some custom code, since Resource::_get_rid() isn't a normal virtual function in 4.3 and earlier.

@dsnopek dsnopek added the bug This has been identified as a bug label Nov 13, 2024
@dsnopek dsnopek changed the title Resource::get_rid is not exposed as virtual [4.3] Resource::get_rid is not exposed as virtual Nov 13, 2024
@dsnopek dsnopek added this to the 4.3 milestone Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This has been identified as a bug
Projects
None yet
Development

No branches or pull requests

2 participants