-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preflight command to show config-repo definition #18
Comments
@ankitsri11 We could also consider it a response of the preflight check (with a verbose flag). |
That way it'll feel more natural. |
@arvindsv @ankitsri11 I agree that a verbose flag would feel more natural. I think I get the idea behind the pipeline list, but I'm slightly confused by the pipeline definition. How does the output differ (or is it the same) from the contents of the file(s)? |
@kierarad The way I see it, it's a confirmation of what the GoCD server has seen. It might become more important when templates are introduced (as is happening here). It could also help in cases such as gocd/gocd#5775 which is based on a real-life failure in feedback. |
@arvindsv got it! Thanks for the additional context. I didn't even consider the case in which no files matched. |
It might be good to make this machine-readable output as well (e.g., JSON). That way, people who want to make integrations to their IDE could get output that's useful. Even better if the config represents only what the server "sees", which may be different than what the user sends (e.g., a user may have included a key that is in the wrong place, or is not understood, but ignored by the server) |
Notes from @marques-work:
Essentially, this is a dupe of #9 (which I just closed in favor of this issue because this one has more context/convo.
Summary of #9:
It would be nice to have a preflight command to display the config-repo definition such as:
Examples:
Add config-repo
./gocd config 'path/to/config-repo/directory'
List down number of pipelines
./gocd configrepo show config-repo
Output:
./gocd configrepo show config-repo pipeline1
Output:
/cc: @arvindsv
The text was updated successfully, but these errors were encountered: