WIP: Add Enumerator class #801
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Nov 16, 2019
| @@ -1367,3 +1374,7 @@ func generateJSONFromPair(key string, v Object, t *Thread) string { | |||
|
|
|||
| return out.String() | |||
| } | |||
|
|
|||
| func (h *HashObject) Enumerable() bool { | |||
There was a problem hiding this comment.
exported method HashObject.Enumerable should have comment or be unexported
| return out | ||
| } | ||
|
|
||
| //// Retrieves an object in an array using Integer index; common to `[]` and `at()`. |
There was a problem hiding this comment.
comment on exported method EnumeratorObject.Len should be of the form "Len ..."
| GoMapClass = "GoMap" | ||
| DecimalClass = "Decimal" | ||
| BlockClass = "Block" | ||
| ObjectClass = "Object" |
There was a problem hiding this comment.
exported const ObjectClass should have comment (or a comment on this block) or be unexported
| @@ -1817,3 +1823,7 @@ func (a *ArrayObject) unshift(objs []Object) *ArrayObject { | |||
| a.Elements = append(objs, a.Elements...) | |||
| return a | |||
| } | |||
|
|
|||
| func (a *ArrayObject) Enumerable() bool { | |||
There was a problem hiding this comment.
exported method ArrayObject.Enumerable should have comment or be unexported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just for my interest regarding #342 .
This apparently works but is still not the real Enumerator class. Currently, only
Array#to_enum,Hash#to_enum,Enumerator#inspectis available. (:eachis a fake😆)