Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

settings are not taken into account since v1.2.3 #62

Closed
glucauze opened this issue Aug 23, 2023 · 12 comments · Fixed by #68
Closed

settings are not taken into account since v1.2.3 #62

glucauze opened this issue Aug 23, 2023 · 12 comments · Fixed by #68
Labels
configuration Problem related to configuration documentation Improvements or additions to documentation wontfix This will not be worked on

Comments

@glucauze
Copy link
Owner

Problem : Settings are not taken into account when modified.

Reason :
This is due to the way settings are no manage. Instead of using a lambda to load the settings (which takes a lot of time), i removed the settings from ui-config.json. This allows to manage the settings a lot more quickly.

Solution :
Migration : YOU NEED TO recreate ui-config.json (delete and restart sd) OR at least remove any faceswaplab reference in the ui-config.json file to be able to use default settings again.

See this for explainations : AUTOMATIC1111/stable-diffusion-webui#6109
@glucauze glucauze added documentation Improvements or additions to documentation wontfix This will not be worked on configuration Problem related to configuration labels Aug 23, 2023
@abline11
Copy link

Unfortunately your mitigation that '
YOU NEED TO recreate ui-config.json (delete) or at least remove any faceswaplab reference to be able to use default settings again' doesn't work.

Having tried both deleting the ui-config.json file entirely so it is recreated AND editing the ui-config.json file to remove all lines referencing faceswaplab it will not remember any of the settings put into the txt2img tab under the FaceSwapLab V1.2.3 pull down in between sessions (i.e. if I go to the Setting tab, then the Defaults option, then click on View Changes, then Apply). In fact, it doesn't even pick up that there are any changes when View Changes is pressed. For example any changes to add a default Face Checkpoint (precedence over reference face) or Genger are not recognised and therefore forgotten.

I even deleted the entire FaceSwapLab extension, and the associated folders for FaceSwapLab in the Models and Extensions folders, and deleted the ui-config.json and once FaceSwapLab was reinstalled fresh still any changes applied in the txt2img tab are not remembered or even recognised when I have tried to set Defaults via the Settings tab.

This is a great extension. Please could you look at this again?

@glucauze
Copy link
Owner Author

glucauze commented Aug 24, 2023 •
edited
Loading

Ok, reverting back would be easy but i need to be sure there is a problem first because the new way of handling parameters reduces load time drastically.

I have tested on linux on sdnext and a1111. I will try to test on windows. Edit : I did test on windows and it's working.

What is your configuration ?

The current version only store parameters that are set on SD setting tabs. Default checkpoint for instance is not possible. All otheer settings are lost. You also need to restart.

There are no settings stored in the ui-config.json as of now. Is that what you are looking for ?

@abline11
Copy link

abline11 commented Aug 24, 2023 via email

@glucauze
Copy link
Owner Author

glucauze commented Aug 24, 2023 •
edited
Loading

Ok, just to be sure because it's puzzling me.

You are using these settings in sd settings :

And these settings are not reflected in txt2img parameters (after restart)?

Or you are expecting the configuration done in txt2img to be persistent (only when modifying it in txt2img tabs) ?

Where you using the settings before 1.2.3 ?

@abline11
Copy link

abline11 commented Aug 24, 2023 via email

@glucauze
Copy link
Owner Author

glucauze commented Aug 24, 2023 •
edited
Loading

Ok thanks ! I got it :

If, for example, I change the Face Checkpoint to Face_3.safetensors it is impossible to make it persistent like all other changes in txt2img (e.g. Restore Faces or Seed)

I made settings do_not_save to be able to adjust settings by myself.

I expect the configurations done in txt2img to be persistent as they always are if you use the Settings/Default. This facility has been available for months in A1111 and worked perfectly in V1.2.2, but is now broken in V1.2.3. Have you never used or tested the Settings/Default facility in A1111?

I don't use this option. That's why. Settings cannot be managed by faceswaplab OR sd. I had to made a choice but but I applied this to all the changes.

I will try to think of a way to handle that properly. I hope it's not too critical in the meantime.

I can mark only the options I set as "do not save" and leave the others or i can add options in the settings. Or i can suppress the default settings in faceswaplab and let the users use the default interface (don't know if it is more user friendly)

Btw i don't see the screenshots, i think they are not uploaded when you reply by mail.

@glucauze glucauze mentioned this issue Aug 24, 2023
Merged
@glucauze glucauze linked a pull request Aug 24, 2023 that will close this issue
V1.2.4 #68
Merged
@glucauze
Copy link
Owner Author

I made a change to mark only fields that are not managed in faceswaplab settings. I think it is working. Would you have time to try and tell me if it is better for you ?

@abline11
Copy link

abline11 commented Aug 24, 2023 via email

@glucauze
Copy link
Owner Author

Don't worry about that, since all the tests are ok and the change is not critical, i will merge the version. You can tell me if it's better by just reinstalling the main branch.

glucauze added a commit that referenced this issue Aug 24, 2023
@glucauze
Merge pull request #68 from glucauze/v1.2.4
9977168 
V1.2.4 :

Fix default settings by marking only managed field as do_not_save.

See the discussion here : #62
@glucauze
Copy link
Owner Author

glucauze commented Aug 24, 2023 •
edited
Loading

Reopening (the merge has closed the issue). Will close if you confirm it works properly.

I have opened a poll in discussion section to ask if faceswaplab should manage default settings : #69

I am starting to think it's a redundant functionality and error-prone. Thanks for making me discover the feature.

@glucauze glucauze reopened this Aug 24, 2023
@abline11
Copy link

abline11 commented Aug 24, 2023 via email

@abline11
Copy link

abline11 commented Aug 25, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
configuration Problem related to configuration documentation Improvements or additions to documentation wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

V1.2.4 glucauze/sd-webui-faceswaplab
2 participants
@abline11 @glucauze