GitLens Compare ... family of commands no longer grabbing focus

[Dzejkop]

It used to be the case that when running, for example, GitLens: Compare Working tree with... I could immediately start typing out the name of the branch that I want to compare against.

Recently that stopped being the case and I'm wondering if it's something that changed in a recent update of this extension or maybe an update of VSCode.

Did anybody else notice this? Do you know if it's possible to force this behaviour with some configuration?

[eamodio]

@TylerLeonhardt Any idea on this one? I can reproduce it, but only on this quick pick where I show the quick pick early and continue to load the items after showing it.

vscode-gitlens/src/quickpicks/referencePicker.ts

Lines 39 to 161 in 16cdd10

	export async function show(
	repoPath: string,
	title: string,
	placeHolder: string,
	options: ReferencesQuickPickOptions = {},
	): Promise<GitReference | undefined> {
	const quickpick = window.createQuickPick<ReferencesQuickPickItem>();
	quickpick.ignoreFocusOut = getQuickPickIgnoreFocusOut();
	quickpick.title = title;
	quickpick.placeholder =
	options.allowEnteringRefs != null
	? `${placeHolder}${GlyphChars.Space.repeat(3)}(or enter a reference using #)`
	: placeHolder;
	quickpick.matchOnDescription = true;
	const disposables: Disposable[] = [];
	let scope: KeyboardScope | undefined;
	if (options?.keys != null && options.keys.length !== 0 && options?.onDidPressKey !== null) {
	scope = Container.instance.keyboard.createScope(
	Object.fromEntries(
	options.keys.map(key => [
	key,
	{
	onDidPressKey: key => {
	if (quickpick.activeItems.length !== 0) {
	void options.onDidPressKey!(key, quickpick);
	}
	},
	},
	]),
	),
	);
	void scope.start();
	disposables.push(scope);
	}
	const cancellation = new CancellationTokenSource();
	let autoPick;
	let items = getItems(repoPath, options);
	if (options.autoPick) {
	items = items.then(itms => {
	if (itms.length <= 1) {
	autoPick = itms[0];
	cancellation.cancel();
	}
	return itms;
	});
	}
	quickpick.busy = true;
	quickpick.enabled = false;
	quickpick.show();
	const getValidateGitReference = getValidateGitReferenceFn(Container.instance.git.getRepository(repoPath), {
	buttons: [QuickCommandButtons.RevealInSideBar],
	ranges:
	options?.allowEnteringRefs && typeof options.allowEnteringRefs !== 'boolean'
	? options.allowEnteringRefs.ranges
	: undefined,
	});
	quickpick.items = await items;
	quickpick.busy = false;
	quickpick.enabled = true;
	try {
	let pick = await new Promise<ReferencesQuickPickItem | undefined>(resolve => {
	disposables.push(
	cancellation.token.onCancellationRequested(() => quickpick.hide()),
	quickpick.onDidHide(() => resolve(undefined)),
	quickpick.onDidAccept(() => {
	if (quickpick.activeItems.length === 0) return;
	resolve(quickpick.activeItems[0]);
	}),
	quickpick.onDidChangeValue(async e => {
	if (options.allowEnteringRefs) {
	if (!(await getValidateGitReference(quickpick, e))) {
	quickpick.items = await items;
	}
	}
	if (scope == null) return;
	// Pause the left/right keyboard commands if there is a value, otherwise the left/right arrows won't work in the input properly
	if (e.length !== 0) {
	await scope.pause(['left', 'right']);
	} else {
	await scope.resume();
	}
	}),
	quickpick.onDidTriggerItemButton(({ button, item: { item } }) => {
	if (button === QuickCommandButtons.RevealInSideBar) {
	if (GitReference.isBranch(item)) {
	void GitActions.Branch.reveal(item, { select: true, expand: true });
	} else if (GitReference.isTag(item)) {
	void GitActions.Tag.reveal(item, { select: true, expand: true });
	} else if (GitReference.isRevision(item)) {
	void GitActions.Commit.showDetailsView(item, {
	pin: false,
	preserveFocus: true,
	});
	}
	}
	}),
	);
	});
	if (pick == null && autoPick != null) {
	pick = autoPick;
	}
	if (pick == null) return undefined;
	return pick.item;
	} finally {
	quickpick.dispose();
	disposables.forEach(d => void d.dispose());
	}
	}

[TylerLeonhardt]

I see you're using enabled... I wonder if this is microsoft/vscode#167478

[eamodio]

Yeah, that was the cause. I ended up removing the changes to the enabled state in these quick picks to avoid it. Thankfully they really didn't have to be disabled while we loaded things.

[TylerLeonhardt]

I'll try to get that bug sorted this month