Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potentially inaccurate time in draft #417

Open
zkoppert opened this issue Oct 25, 2024 · 2 comments · May be fixed by #431
Open

Potentially inaccurate time in draft #417

zkoppert opened this issue Oct 25, 2024 · 2 comments · May be fixed by #431
Labels
bug Something isn't working good first issue Good for newcomers keep

Comments

@zkoppert
Copy link
Member

Describe the bug

The time in draft function assumes that the pr is opened as a draft which is not always true and if a PR goes into draft after being in a ready for review state, the draft time time after a ready for review state is not counted. It is also not cumulative.

To Reproduce

  1. Run the action with Time in Draft enabled on pull requests that have moved into draft state after being ready for review.

Expected behavior

Ideally we would add up all the time in draft for a pr and record that as "Time in draft".

Screenshots

No response

Additional context

No response

@zkoppert zkoppert added bug Something isn't working good first issue Good for newcomers labels Oct 25, 2024
Copy link

This issue is stale because it has been open 21 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the Stale label Nov 16, 2024
@zkoppert zkoppert added keep and removed Stale labels Nov 16, 2024
@brokoli777
Copy link

Hi! I would like to work on this. I had some doubts on what event to search but I found that there is a event called "converted_to_draft" that can be used.
image

I will try using that similar to how time_to_ready_for_review.py is done:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers keep
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants