Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DiffThunkRange access #2620

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix DiffThunkRange access #2620

wants to merge 1 commit into from

Conversation

cklin
Copy link
Contributor

@cklin cklin commented Nov 21, 2024

This PR fixes lingering array index access that I missed when I converted getPullRequestEditedDiffRanges() results from tuples to DiffThunkRange objects.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 21, 2024
View reviewed changes
src/analyze.ts Fixed Show fixed Hide fixed
@cklin
Fix DiffThunkRange access
2eea97e 
This commit fixes lingering array index access that I missed when I
converted getPullRequestEditedDiffRanges() results from tuples to
DiffThunkRange objects.
@cklin cklin marked this pull request as ready for review November 21, 2024 22:05
@cklin cklin requested a review from a team as a code owner November 21, 2024 22:05
angelapwen
angelapwen approved these changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@angelapwen angelapwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this! 🧹

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angelapwen angelapwen angelapwen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cklin @angelapwen