refine: return error when response writer doesn't plement hijacker #4026
+8
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change tries to align with the H2C behavior, which returns an error when the response writer doesn't implement the hijacker api. https://github.com/golang/net/blob/master/http2/h2c/h2c.go#L137
The panic could be demonstrated as the gist reveals: https://gist.github.com/xieyuschen/ff525642e576de14729b9b9214c656f5
I raised this PR because during our H2C integration with gin, we found this potential panic which is better to be fixed from the framework side. It's an improvement specifically to the HTTP/2 case. It's not a breaking change and could help integrate gin with H2C.
Regards