Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Complete automated tests for Filter#toString #3694

Open
chrmod opened this issue Jan 8, 2024 · 2 comments
Open

Complete automated tests for Filter#toString #3694

chrmod opened this issue Jan 8, 2024 · 2 comments
Assignees
@seia-soto

Comments

@chrmod
Copy link
Member

chrmod commented Jan 8, 2024

Lets be sure that NetworkFilter#toString is able to correctly export all supported filter types.
@chrmod
Copy link
Member Author

chrmod commented Jan 8, 2024

when working on #3681 I've noticed some unexpected behaviour - I think simple filter like foo.com^ was converted to something quite longer.

@chrmod
Copy link
Member Author

chrmod commented Feb 22, 2024

require('@cliqz/adblocker').NetworkFilter.parse('foo.com^').toString()

@seia-soto seia-soto mentioned this issue Apr 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@seia-soto seia-soto

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: network filter ending with right hat recognized as regex seia-soto/adblocker
2 participants
@chrmod @seia-soto