Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Item becomes active too early #88

Open
pozitron57 opened this issue Oct 29, 2015 · 5 comments · May be fixed by #112
Open

Item becomes active too early #88

pozitron57 opened this issue Oct 29, 2015 · 5 comments · May be fixed by #112

Comments

@pozitron57
Copy link

pozitron57 commented Oct 29, 2015

Hi there,

First of all, thank you for tocify!

I have an issue: if one header is far from the other, the entry becomes active too early when you scroll down. You can see it on the test page. Just scroll down.

Is it intended behavior or I messed something up? I tried setting different values for highlightOffset with no luck.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@alexey-yanchenko
Copy link

Grab _jquery.tocify.js from lord/slate repo, file contains a fix

@jenlampton
Copy link

jenlampton commented Jun 17, 2019

@alexey-yanchenko the link to _jquery.tocify.js 404s. I'm also suffering from this bug, do you happen to know what the fix was? Or even, know what version of lord/slate your fix was in? It looks like version 1.4 almost lines up with date to your comment here. I'll start there.

I'd like to post a PR here so everyone can benefit from having this fix in TOC itself.

@gfranko
Copy link
Owner

gfranko commented Jun 17, 2019

I haven't had time to maintain this repository for the last few years, so if anyone would like a particular fix just send me a tip via Paypal and I'll look into it

@jenlampton
Copy link

Thanks @gfranko, it's a cool little lib, and thanks for all your work on it in the past! :)

jenlampton pushed a commit to jenlampton/jquery.tocify.js that referenced this issue Jun 20, 2019
@jenlampton jenlampton linked a pull request Jun 20, 2019 that will close this issue
@jenlampton
Copy link

Okay, I took version 1.4 of lord/slate and made a diff between _jquery.tocify.js and version 1.8 of jquery.tocify.js. I then applied that diff to the 1.9 version of jquery.tocify.js and created a pr: #112

I'm not very good with JavaScript, so I didn't try to pick out only the changes that I thought were relevant to this issue, but I can confirm that the item becoming active too early is no longer an issue on my site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants