Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate trace without the Performance Monitoring #45725

Closed
4 tasks
bruno-garcia opened this issue Mar 13, 2023 · 2 comments
Closed
4 tasks

Propagate trace without the Performance Monitoring #45725

bruno-garcia opened this issue Mar 13, 2023 · 2 comments

Comments

@bruno-garcia
Copy link
Member

bruno-garcia commented Mar 13, 2023

Distributed Tracing built-in to Sentry landed with the addition of Sentry for Performance Monitoring, the SDKs started creating a sentry-trace header for out going HTTP requests. Backend SDKs became aware of those and further propagated the trace information, as well as adding it to any outgoing events: errors or transactions.

For the most part a trace-id is created when a transaction (event used for performance monitoring) is created. And while the transaction exists (and bound to the scope), that trace-id is propagated through HTTP integrations.

With other products landing such as Session Replay, the need to connect a Replay throughout the whole call chain became more prominent. We can do that today if we rely on sentry-trace being propagated but that requires performance monitoring being enabled. That was a constraint to the initial deliverable of having Replay show up on backend errors:

This issue aims to decouple trace propagation and transactions or the performance product. So errors, replays, etc can be linked together across from the frontend to backend services.

Initial action points

@smeubank
Copy link
Member

smeubank commented Mar 22, 2023

Hi 👋 @bruno-garcia

getsentry/develop#885

I will follow up with this in TSC, essentially i think the best as is. Will be define this is a non-breaking change and expected behavior to get traces and turn off perofrmance tracesSampleRate: 0.0

for OTel, the OTel SDK really runs the show for propagation, should work as is, I also don't imagine many OTel users would want to have an errors and replay only product experience

@github-actions
Copy link
Contributor

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@github-actions github-actions bot locked and limited conversation to collaborators May 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants