feat: extend performance API with explicit timings #1093
+259
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1093 +/- ##
==========================================
+ Coverage 82.40% 82.46% +0.05%
==========================================
Files 53 53
Lines 7760 7806 +46
Branches 1215 1215
==========================================
+ Hits 6395 6437 +42
- Misses 1254 1258 +4
Partials 111 111 |
JoshuaMoelans
commented
Nov 29, 2024
| event_id = sentry_transaction_finish(tx); | ||
| TEST_CHECK(!sentry_uuid_is_nil(&event_id)); | ||
| if (timestamped) { | ||
| sentry_uuid_t event_id = sentry_transaction_finish_ts(tx, 4); |
There was a problem hiding this comment.
Since the transaction gets destroyed at this point, I'm not sure if there is a unit-test way to check if the timestamp got set correctly. Would we need an integration test for this?
JoshuaMoelans
commented
Nov 29, 2024
| @@ -378,7 +378,7 @@ sentry__value_span_new_n(size_t max_spans, sentry_value_t parent, | |||
| sentry_value_new_string_n(description.ptr, description.len)); | |||
| sentry_value_set_by_key(child, "start_timestamp", | |||
| sentry__value_new_string_owned( | |||
| sentry__usec_time_to_iso8601(sentry__usec_time()))); | |||
| sentry__usec_time_to_iso8601(timestamp))); | |||
There was a problem hiding this comment.
Should our API's in-code docs mention what kind of timestamp we 'expect' (e.g. a value relative to the epoch time)?
There was a problem hiding this comment.
Yes, and also that the unit of time is microseconds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #941