Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crashpad crashes when cleaning the database #1064

Open
supervacuus opened this issue Oct 29, 2024 · 0 comments
Open

crashpad crashes when cleaning the database #1064

supervacuus opened this issue Oct 29, 2024 · 0 comments
Labels
area: backend backend: crashpad bug Something isn't working Platform: Native upstream The issue is related to an upstream dependency

Comments

@supervacuus
Copy link
Collaborator

supervacuus commented Oct 29, 2024

This happens in the field:

Image

It seems int int CrashReportDatabaseWin::CleanDatabase(time_t lockfile_ttl) isn't checking for failed std::unique_ptr<Metadata> CrashReportDatabaseWin::AcquireMetadata() (which can fail if the metadata_file can't be opened or the following file-lock failed)

https://github.com/getsentry/crashpad/blob/59fc31ce00d245d59cff282f5ee8f0785b710a2c/client/crash_report_database_win.cc#L970-L1001

All other functions acquiring metadata check the return value and exit immediately. This should be upstreamed.

@supervacuus supervacuus added bug Something isn't working backend: crashpad area: backend upstream The issue is related to an upstream dependency labels Oct 29, 2024
@kahest kahest moved this from Needs Discussion to Backlog in Mobile & Cross Platform SDK Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: backend backend: crashpad bug Something isn't working Platform: Native upstream The issue is related to an upstream dependency
Projects
Status: Backlog
Development

No branches or pull requests

1 participant