Skip to content
This repository has been archived by the owner on Aug 30, 2023. It is now read-only.

Add custom parameters to HTTPTrasport and setters #253

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

sshaplygin
Copy link
Contributor

It is modify PR #222 with custom HTTPTransport
client parameters.

@kamilogorek
Copy link
Contributor

PR introduces options

// HTTPTransportOptions are options to configure the HTTPTransport
yet it contains 5 separate setters for all the timeouts.

Wouldn't it be better to configure it once during transport creation? It will most likely never change once configured anyway.

@sshaplygin
Copy link
Contributor Author

@kamilogorek Hi!
It is good idea.
I gonna fix soon time

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants