Skip to content
This repository has been archived by the owner on Aug 30, 2023. It is now read-only.

Memory Issue When Application Sends Too Many Errors #34

Open
allisonwang opened this issue Oct 22, 2018 · 1 comment
Open

Memory Issue When Application Sends Too Many Errors #34

allisonwang opened this issue Oct 22, 2018 · 1 comment

Comments

@allisonwang
Copy link

We are using AioHttpTransport when sending errors to Sentry. But (based on the documentation here "Each new message spawns it owns asyncio.Task, amount of them is not limited") if the application keeps sending large amount of error messages, this will cause memory leak and eventually the box will run out of memory. But if we use QueuedAioHttpTransport, the extra errors will simply get omitted if the queue is full.

I am wondering what's the best way to handle this issue?

@Kentzo
Copy link

Kentzo commented Oct 26, 2018

Thoughts:

  1. Modify QueuedAioHttpTransport to be blocking
  2. Keep track of what errors are already sent and discard duplicates

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants