From 7fa73cc5dd8b7c4bdb24e34d0c09bf5102254e55 Mon Sep 17 00:00:00 2001 From: Lukas Stracke Date: Thu, 3 Aug 2023 20:23:02 +0200 Subject: [PATCH] fix tests w/o formatting changes --- .../__tests__/github.test.ts | 351 ++++++++---------- 1 file changed, 165 insertions(+), 186 deletions(-) diff --git a/src/artifact_providers/__tests__/github.test.ts b/src/artifact_providers/__tests__/github.test.ts index 2442f1fe..35300ac4 100644 --- a/src/artifact_providers/__tests__/github.test.ts +++ b/src/artifact_providers/__tests__/github.test.ts @@ -1,21 +1,13 @@ jest.mock('../../utils/githubApi.ts'); -import { getGitHubClient } from '../../utils/githubApi'; -import { - GitHubArtifactProvider, - ArtifactItem, - lazyRequest, - lazyRequestCallback, -} from '../github'; +import { getGitHubClient} from '../../utils/githubApi'; +import { GitHubArtifactProvider, ArtifactItem, lazyRequest, lazyRequestCallback} from '../github'; import { sleep } from '../../utils/async'; class TestGitHubArtifactProvider extends GitHubArtifactProvider { public testGetRevisionArtifact(revision: string): Promise { return this.getRevisionArtifact(revision); } - public testSearchForRevisionArtifact( - revision: string, - getRevisionDate: lazyRequestCallback - ): Promise { + public testSearchForRevisionArtifact(revision: string, getRevisionDate: lazyRequestCallback): Promise { return this.searchForRevisionArtifact(revision, getRevisionDate); } } @@ -26,11 +18,11 @@ describe('GitHub Artifact Provider', () => { let githubArtifactProvider: TestGitHubArtifactProvider; let mockClient: { actions: { - listArtifactsForRepo: jest.Mock; - }; + listArtifactsForRepo: jest.Mock, + }, git: { - getCommit: jest.Mock; - }; + getCommit: jest.Mock, + }, }; let mockedSleep; @@ -54,7 +46,7 @@ describe('GitHub Artifact Provider', () => { mockedSleep = sleep as jest.Mock; mockedSleep.mockImplementation(() => { - return new Promise(resolve => setTimeout(resolve, 10)); + return new Promise((resolve) => setTimeout(resolve, 10)); }); }); @@ -121,56 +113,54 @@ describe('GitHub Artifact Provider', () => { status: 200, data: { committer: { - date: '2021-05-12T21:45:04Z', + date: "2021-05-12T21:45:04Z", }, }, + }) + mockClient.actions.listArtifactsForRepo.mockResolvedValueOnce({ + status: 200, + data: { + // NOTE: 101 here will force pagination to be handled. + total_count: 101, + artifacts: [ + { + id: 60232691, + node_id: 'MDg6QXJ0aWZhY3Q2MDIzMjY5MQ==', + name: 'e4bcfe450e0460ec5f20b20868664171effef6f9', + size_in_bytes: 6511029, + url: + 'https://api.github.com/repos/getsentry/craft/actions/artifacts/60232691', + archive_download_url: + 'https://api.github.com/repos/getsentry/craft/actions/artifacts/60232691/zip', + expired: false, + created_at: '2021-05-12T21:45:04Z', + updated_at: '2021-05-12T21:45:07Z', + expires_at: '2021-08-10T21:45:00Z', + }, + ], + }, + }).mockResolvedValueOnce({ + status: 200, + data: { + total_count: 101, + artifacts: [ + { + id: 60233710, + node_id: 'MDg6QXJ0aWZhY3Q2MDIzMzcxMA==', + name: '1b843f2cbb20fdda99ef749e29e75e43e6e43b38', + size_in_bytes: 6511029, + url: + 'https://api.github.com/repos/getsentry/craft/actions/artifacts/60233710', + archive_download_url: + 'https://api.github.com/repos/getsentry/craft/actions/artifacts/60233710/zip', + expired: false, + created_at: '2021-05-12T21:50:35Z', + updated_at: '2021-05-12T21:50:38Z', + expires_at: '2021-08-10T21:50:31Z', + }, + ], + }, }); - mockClient.actions.listArtifactsForRepo - .mockResolvedValueOnce({ - status: 200, - data: { - // NOTE: 101 here will force pagination to be handled. - total_count: 101, - artifacts: [ - { - id: 60232691, - node_id: 'MDg6QXJ0aWZhY3Q2MDIzMjY5MQ==', - name: 'e4bcfe450e0460ec5f20b20868664171effef6f9', - size_in_bytes: 6511029, - url: - 'https://api.github.com/repos/getsentry/craft/actions/artifacts/60232691', - archive_download_url: - 'https://api.github.com/repos/getsentry/craft/actions/artifacts/60232691/zip', - expired: false, - created_at: '2021-05-12T21:45:04Z', - updated_at: '2021-05-12T21:45:07Z', - expires_at: '2021-08-10T21:45:00Z', - }, - ], - }, - }) - .mockResolvedValueOnce({ - status: 200, - data: { - total_count: 101, - artifacts: [ - { - id: 60233710, - node_id: 'MDg6QXJ0aWZhY3Q2MDIzMzcxMA==', - name: '1b843f2cbb20fdda99ef749e29e75e43e6e43b38', - size_in_bytes: 6511029, - url: - 'https://api.github.com/repos/getsentry/craft/actions/artifacts/60233710', - archive_download_url: - 'https://api.github.com/repos/getsentry/craft/actions/artifacts/60233710/zip', - expired: false, - created_at: '2021-05-12T21:50:35Z', - updated_at: '2021-05-12T21:50:38Z', - expires_at: '2021-08-10T21:50:31Z', - }, - ], - }, - }); await expect( githubArtifactProvider.testGetRevisionArtifact( '1b843f2cbb20fdda99ef749e29e75e43e6e43b38' @@ -320,56 +310,52 @@ describe('GitHub Artifact Provider', () => { describe('searchForRevisionArtifact', () => { test('it should get the artifact from second page', async () => { - mockClient.actions.listArtifactsForRepo - .mockResolvedValueOnce({ - status: 200, - data: { - // NOTE: 101 here will force pagination to be handled. - total_count: 101, - artifacts: [ - { - id: 60232691, - node_id: 'MDg6QXJ0aWZhY3Q2MDIzMjY5MQ==', - name: 'e4bcfe450e0460ec5f20b20868664171effef6f9', - size_in_bytes: 6511029, - url: - 'https://api.github.com/repos/getsentry/craft/actions/artifacts/60232691', - archive_download_url: - 'https://api.github.com/repos/getsentry/craft/actions/artifacts/60232691/zip', - expired: false, - created_at: '2021-05-12T21:45:04Z', - updated_at: '2021-05-12T21:45:07Z', - expires_at: '2021-08-10T21:45:00Z', - }, - ], - }, - }) - .mockResolvedValueOnce({ - status: 200, - data: { - total_count: 101, - artifacts: [ - { - id: 60233710, - node_id: 'MDg6QXJ0aWZhY3Q2MDIzMzcxMA==', - name: '1b843f2cbb20fdda99ef749e29e75e43e6e43b38', - size_in_bytes: 6511029, - url: - 'https://api.github.com/repos/getsentry/craft/actions/artifacts/60233710', - archive_download_url: - 'https://api.github.com/repos/getsentry/craft/actions/artifacts/60233710/zip', - expired: false, - created_at: '2021-05-12T21:50:35Z', - updated_at: '2021-05-12T21:50:38Z', - expires_at: '2021-08-10T21:50:31Z', - }, - ], - }, - }); + mockClient.actions.listArtifactsForRepo.mockResolvedValueOnce({ + status: 200, + data: { + // NOTE: 101 here will force pagination to be handled. + total_count: 101, + artifacts: [ + { + id: 60232691, + node_id: 'MDg6QXJ0aWZhY3Q2MDIzMjY5MQ==', + name: 'e4bcfe450e0460ec5f20b20868664171effef6f9', + size_in_bytes: 6511029, + url: + 'https://api.github.com/repos/getsentry/craft/actions/artifacts/60232691', + archive_download_url: + 'https://api.github.com/repos/getsentry/craft/actions/artifacts/60232691/zip', + expired: false, + created_at: '2021-05-12T21:45:04Z', + updated_at: '2021-05-12T21:45:07Z', + expires_at: '2021-08-10T21:45:00Z', + }, + ], + }, + }).mockResolvedValueOnce({ + status: 200, + data: { + total_count: 101, + artifacts: [ + { + id: 60233710, + node_id: 'MDg6QXJ0aWZhY3Q2MDIzMzcxMA==', + name: '1b843f2cbb20fdda99ef749e29e75e43e6e43b38', + size_in_bytes: 6511029, + url: + 'https://api.github.com/repos/getsentry/craft/actions/artifacts/60233710', + archive_download_url: + 'https://api.github.com/repos/getsentry/craft/actions/artifacts/60233710/zip', + expired: false, + created_at: '2021-05-12T21:50:35Z', + updated_at: '2021-05-12T21:50:38Z', + expires_at: '2021-08-10T21:50:31Z', + }, + ], + }, + }); - const getRevisionDateCallback = jest - .fn() - .mockResolvedValueOnce('2020-05-12T21:45:04Z'); + const getRevisionDateCallback = jest.fn().mockResolvedValueOnce("2020-05-12T21:45:04Z"); await expect( githubArtifactProvider.testSearchForRevisionArtifact( @@ -397,78 +383,73 @@ describe('GitHub Artifact Provider', () => { }); test('it should return null if all pages are processed', async () => { - mockClient.actions.listArtifactsForRepo - .mockResolvedValueOnce({ - status: 200, - data: { - // NOTE: 201 here will force pagination to be handled. - total_count: 201, - artifacts: [ - { - id: 60232691, - node_id: 'MDg6QXJ0aWZhY3Q2MDIzMjY5MQ==', - name: 'e4bcfe450e0460ec5f20b20868664171effef6f9', - size_in_bytes: 6511029, - url: - 'https://api.github.com/repos/getsentry/craft/actions/artifacts/60232691', - archive_download_url: - 'https://api.github.com/repos/getsentry/craft/actions/artifacts/60232691/zip', - expired: false, - created_at: '2021-05-12T21:45:04Z', - updated_at: '2021-05-12T21:45:07Z', - expires_at: '2021-08-10T21:45:00Z', - }, - ], - }, - }) - .mockResolvedValueOnce({ - status: 200, - data: { - total_count: 201, - artifacts: [ - { - id: 60232691, - node_id: 'MDg6QXJ0aWZhY3Q2MDIzMjY5MQ==', - name: 'e4bcfe450e0460ec5f20b20868664171effef6f9', - size_in_bytes: 6511029, - url: - 'https://api.github.com/repos/getsentry/craft/actions/artifacts/60232691', - archive_download_url: - 'https://api.github.com/repos/getsentry/craft/actions/artifacts/60232691/zip', - expired: false, - created_at: '2021-05-12T21:45:04Z', - updated_at: '2021-05-12T21:45:07Z', - expires_at: '2021-08-10T21:45:00Z', - }, - ], - }, - }) - .mockResolvedValueOnce({ - status: 200, - data: { - total_count: 201, - artifacts: [ - { - id: 60232691, - node_id: 'MDg6QXJ0aWZhY3Q2MDIzMjY5MQ==', - name: 'e4bcfe450e0460ec5f20b20868664171effef6f9', - size_in_bytes: 6511029, - url: - 'https://api.github.com/repos/getsentry/craft/actions/artifacts/60232691', - archive_download_url: - 'https://api.github.com/repos/getsentry/craft/actions/artifacts/60232691/zip', - expired: false, - created_at: '2021-05-12T21:45:04Z', - updated_at: '2021-05-12T21:45:07Z', - expires_at: '2021-08-10T21:45:00Z', - }, - ], - }, - }); + mockClient.actions.listArtifactsForRepo.mockResolvedValueOnce({ + status: 200, + data: { + // NOTE: 201 here will force pagination to be handled. + total_count: 201, + artifacts: [ + { + id: 60232691, + node_id: 'MDg6QXJ0aWZhY3Q2MDIzMjY5MQ==', + name: 'e4bcfe450e0460ec5f20b20868664171effef6f9', + size_in_bytes: 6511029, + url: + 'https://api.github.com/repos/getsentry/craft/actions/artifacts/60232691', + archive_download_url: + 'https://api.github.com/repos/getsentry/craft/actions/artifacts/60232691/zip', + expired: false, + created_at: '2021-05-12T21:45:04Z', + updated_at: '2021-05-12T21:45:07Z', + expires_at: '2021-08-10T21:45:00Z', + }, + ], + }, + }).mockResolvedValueOnce({ + status: 200, + data: { + total_count: 201, + artifacts: [ + { + id: 60232691, + node_id: 'MDg6QXJ0aWZhY3Q2MDIzMjY5MQ==', + name: 'e4bcfe450e0460ec5f20b20868664171effef6f9', + size_in_bytes: 6511029, + url: + 'https://api.github.com/repos/getsentry/craft/actions/artifacts/60232691', + archive_download_url: + 'https://api.github.com/repos/getsentry/craft/actions/artifacts/60232691/zip', + expired: false, + created_at: '2021-05-12T21:45:04Z', + updated_at: '2021-05-12T21:45:07Z', + expires_at: '2021-08-10T21:45:00Z', + }, + ], + }, + }).mockResolvedValueOnce({ + status: 200, + data: { + total_count: 201, + artifacts: [ + { + id: 60232691, + node_id: 'MDg6QXJ0aWZhY3Q2MDIzMjY5MQ==', + name: 'e4bcfe450e0460ec5f20b20868664171effef6f9', + size_in_bytes: 6511029, + url: + 'https://api.github.com/repos/getsentry/craft/actions/artifacts/60232691', + archive_download_url: + 'https://api.github.com/repos/getsentry/craft/actions/artifacts/60232691/zip', + expired: false, + created_at: '2021-05-12T21:45:04Z', + updated_at: '2021-05-12T21:45:07Z', + expires_at: '2021-08-10T21:45:00Z', + }, + ], + }, + }); - const getRevisionDateCallback = jest - .fn() - .mockResolvedValueOnce('2020-05-12T21:45:04Z'); + const getRevisionDateCallback = jest.fn().mockResolvedValueOnce("2020-05-12T21:45:04Z"); await expect( githubArtifactProvider.testSearchForRevisionArtifact( @@ -505,9 +486,7 @@ describe('GitHub Artifact Provider', () => { }, }); - const getRevisionDateCallback = jest - .fn() - .mockResolvedValueOnce('2021-05-12T21:45:04Z'); + const getRevisionDateCallback = jest.fn().mockResolvedValueOnce( "2021-05-12T21:45:04Z"); await expect( githubArtifactProvider.testSearchForRevisionArtifact(