Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit assertion vs warning in preprocessing script #152

Open
jmelot opened this issue Sep 6, 2022 · 0 comments
Open

Revisit assertion vs warning in preprocessing script #152

jmelot opened this issue Sep 6, 2022 · 0 comments
Assignees

Comments

@jmelot
Copy link
Member

jmelot commented Sep 6, 2022

I've moved to assertions in cases where we've discussed the check and should break preprocessing if it fails, but weshould be thoughtful about when we do this, as Neha notes below. I will think about this again later.

Not blocking. The general trend in this file has been to convert printed warnings to assert statements. Should this also become an assert someday?

Originally posted by @niharikasingh in #110 (comment)

@jmelot jmelot self-assigned this Sep 6, 2022
@jmelot jmelot added this to the December Release milestone Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant