Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GeoJSON file path is not relative to the jGIS file #39

Closed
martinRenou opened this issue Jul 11, 2024 · 2 comments · Fixed by #38
Closed

GeoJSON file path is not relative to the jGIS file #39

martinRenou opened this issue Jul 11, 2024 · 2 comments · Fixed by #38
Labels
bug Something isn't working
Milestone

Comments

@martinRenou
Copy link
Member

Our logic to read the GeoJSON file path is not relative to the jGIS file, but to the server runtime path.

@martinRenou martinRenou added the bug Something isn't working label Jul 11, 2024
@martinRenou martinRenou added this to the 1.0.0 milestone Jul 11, 2024
@davidbrochart
Copy link
Collaborator

I feel that having side files that are not referenced by a universal path (like a URL) is going to be a source of issues.
Maybe we could optionally bundle everything in a single archive, or something like SpatialLite?

@martinRenou
Copy link
Member Author

I'm about to push a fix to the original issue in #38

I feel that having side files that are not referenced by a universal path (like a URL) is going to be a source of issues.

Yeah, in the case of the Python API I think we don't have a choice but to embed the JSON data. The kernel may be running in whatever machine and we don't know what local file it may reference to unless it's explicitly uploaded to the JupyterLab drive.
I believe that when selected from the UI, it is fine and it is reliable to reference a JupyterLab drive file path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants