Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated internal workloads loading to allow support for suites. #11

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

helloparthshah
Copy link
Contributor

@helloparthshah helloparthshah commented Feb 22, 2024

Suites currently are reusing the workloads field which was being used for internal reverse mapping for the website. This PR updates the internal field to be workloads_mapping in order to keep support for displaying suites.

This PR also updates the logic for displaying tabs with nested data structures (list of objects) to be displayed as JSON instead of list of strings.

Ref:
Before: http://resources.gem5.org/resources/npb-benchmark-suite/raw?database=gem5-resources&version=1.0.0
After: http://projects.helloparthshah.me/gem5-resources-website/resources/npb-benchmark-suite/raw?database=gem5-resources&version=1.0.0

Copy link
Contributor

@Harshil2107 Harshil2107 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kunpai
Copy link
Contributor

kunpai commented Feb 22, 2024

LGTM

@Harshil2107 Harshil2107 merged commit 16a8a58 into gem5:main Feb 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants