Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Remove/Relax Matplotlib version requirement #111

Open
acarafat opened this issue Oct 11, 2023 · 5 comments
Open

[FEAT] Remove/Relax Matplotlib version requirement #111

acarafat opened this issue Oct 11, 2023 · 5 comments

Comments

@acarafat
Copy link

Hello,

We are developing a genome annotation and visualization program beav that relies on Integron Finder. We are using Bioconda to distribute our program. Our visualization script requires Matplotlib >= 3.5.2, whereas the Integron Finder specifies the version ==3.3.3 in the Bioconda recipe. I was wondering if you can possibly remove/relax the requirement.

Thank you so much!

@jeanrjc
Copy link
Contributor

jeanrjc commented Oct 12, 2023

I guess it should be possible. Is there any pb with Matplotlib 3.5.2 @bneron ?

You could also propose a PR, we're short on time to dev Integronfinder right now.

@acarafat
Copy link
Author

Thank you so much @jeanrjc. Should I go ahead to propose a PR in the Bioconda recipe?

@bneron
Copy link
Contributor

bneron commented Oct 13, 2023

yes originally I fixed the version to fix some problem in conda in package resolution. but IF works well with matplotlib 3.5.2
So if bioconda can solve the packages dependancies there is no reason to stick on 3.3.3 version

@acarafat
Copy link
Author

@bneron @jeanrjc I relaxed the matplotlib version requirement from ==3.3.3 to >=3.3.3 in the Bioconda recipie yaml file. I'll test once the build complete. Thanks!

@acarafat
Copy link
Author

@bneron @jeanrjc The bioconda build was successful: bioconda/bioconda-recipes#43671

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants