Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

script doesn't entirely blank existing commit tiles #33

Open
numberoverzero opened this issue May 31, 2016 · 2 comments
Open

script doesn't entirely blank existing commit tiles #33

numberoverzero opened this issue May 31, 2016 · 2 comments

Comments

@numberoverzero
Copy link
Contributor

It looks like existing commits aren't being pushed below the threshold for the tile coloring even when using the gitfiti option (which I think uses max_commits^2 if I'm reading the source correctly, but probably not).

In my run, this resulted in the surrounding pixels staying the lightest green color, and a stray darker green pixel inside the oneup (below the left eye).

The changes aren't taking a day for me to see, I think you can force a redraw by toggling the new contribution setting.

Before:

gitfiti-before

After:

gitfiti-after

My input when running the script:

Enter github url
Enter nothing for https://github.com/ to be used: 
Enter your github username:
>numberoverzero
Enter name of the repo to be used by gitfiti:
>$REPO
Enter the number of weeks to offset the image (from the left):
>8
By default gitfiti.py matches the darkest pixel to the highest
number of commits found in your github commit/activity calendar,

Currently this is : 38 commits

Enter the word "gitfiti" to exceed your max
(this option generates WAY more commits)
Any other input will cause the default matching behavior
>gitfiti
enter file(s) to load images from (blank if not applicable)
>
enter the image name to gitfiti
images: oneup, kitty, octocat, oneup_str, hello, hackerschool, octocat2, oneup2, hireme
>oneup2
gitfiti.sh saved.
Create a new(!) repo at: https://github.com/new and run it.
@gelstudios
Copy link
Owner

gelstudios commented Jun 1, 2016

interesting, what's happening here is that the commit count for the day/pixel under the mushroom's eye is being added to the commits generated by gitfiti. So any tile touched by gitfiti will have at least existing commits + new commits.

You could try changing the multiplier to severely scale down existing commits relative to the new.

I guess gitifiti could figure out a given day's commit count and subtract that number from the proposed gitfiti input...

@trickpattyFH20
Copy link

same issue here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants