Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide different feedback options? #10

Open
mxmilkiib opened this issue Jan 7, 2024 · 3 comments
Open

Provide different feedback options? #10

mxmilkiib opened this issue Jan 7, 2024 · 3 comments

Comments

@mxmilkiib
Copy link

mxmilkiib commented Jan 7, 2024

There are a couple of Android apps that I use for harmonic mixing that provide more specific/detailed options for possible transitions.

I'll attach some screenshots.

Might it be possible to implement these in the system?

Screenshot_20240107-064706_Harmonic Mix.png

Screenshot_20240107-064710_Harmonic Mix.png

Screenshot_20240107-064726_Harmonic Mix.png

Screenshot_20240107-064721_Harmonic Mix.png

Screenshot_20240107-065041.png

Screenshot_20240107-065044.png

Screenshot_20240107-065032.png

Screenshot_20240107-065035.png

Screenshot_20240107-065058.png

Screenshot_20240107-065102.png

Screenshot_20240107-065148.png

Screenshot_20240107-065108.png

Screenshot_20240107-070152.png

Screenshot_20240107-065130.png

@geeves
Copy link
Owner

geeves commented Jan 8, 2024

Thanks for the feedback. I checked out your fork and liked it. Definitely some good updates here that can be incorporated. I just need to find a weekend to implement them. That said - keep up the good work!

@geeves
Copy link
Owner

geeves commented Jan 8, 2024

I'd probably put these rules into this project as well - this one is more of just for fun and not to be taken seriously, but it's based on the basic rules of this project.

https://github.com/geeves/setlist-generator

@mxmilkiib
Copy link
Author

mxmilkiib commented Jan 9, 2024

I don't know React or much JS framework stuff, but I extrapolated, fixed some things and hacked a few extra things in (including some of the CSS).

Implement them in yours however you wish, that's probably cleaner for you, and easier for me doing it by git, though I did try to separate several commits.

I'm unsure how to make the clicked note get a unique class so it can be a different colour from the compatible/related notes that are highlighted. Also, with the combined compatible+energy boost view, arguably it would be a better UX if the energy boost notes were different colours, like the app screenshots above. My 2p anyway!

I also guess that probably the "semi-tone" and "whole tone" data should also include the respective minors or majors as well..?

Maybe there is also possibility for changing or adding other note relations. I was wondering if the code could be made into like a modular function that knows to wrap around from 12 to 1, so that there doesn't need to be all the sets of data, but I don't mind data entry once I get into the flow of it so I just went for making the changes :)

I'm primaraly using Mixxx, and was using the Android app, but it has adverts if you're not techy enough to block ads using DNS or a local VPN, and a friend has an iPhone, so I checked out the available web based projects to make it easier for others to access.

And this is the first time I've used Vercel, pretty easy build on commit thing, like Netlify, linked it to the GH project, given the basic build commands and a root public directory value.

P.S. for anyone else reading along, the alternate version I made; https://harmonicwheel.vercel.app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants