Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add salutation to the contact form #579

Open
mike-podolskiy90 opened this issue Aug 8, 2024 · 5 comments
Open

Add salutation to the contact form #579

mike-podolskiy90 opened this issue Aug 8, 2024 · 5 comments

Comments

@mike-podolskiy90
Copy link
Contributor

There's a new field in the IPT salutation. It should be added to the registry UI (contact -> salutation).

@MortenHofft
Copy link
Member

MortenHofft commented Aug 8, 2024

Since the backend isn't there yet I will need someone to revive this issue once it is ready. I would think the backend could go into production first unless you have concerns about the implementation and want the UI to test it first. But it sounds like a simple change.

@mike-podolskiy90
Copy link
Contributor Author

This field is already added in gbif-api and registry should understand it. We just also need to store it into DB.
So, I think there's no obstacles to implement the UI

@mike-podolskiy90
Copy link
Contributor Author

I've added a database column and deployed registry ot UAT
@MortenHofft would you be able to implement it or point me the place so I can submit a PR?

@MortenHofft
Copy link
Member

MortenHofft commented Aug 19, 2024

I miss some information. Is it a string, enum? Are there examples? It is in the API you write, but not stored in the DB. Then how do i test it, if it isn't stored anywhere? Does it go for all contacts (networks, installations, datasets, collections etc)?

@MortenHofft
Copy link
Member

MortenHofft commented Aug 19, 2024

From conversation: it is a string. It is actually stored in the database
Should now be available at https://registry.gbif-uat.org/dataset/0b73f520-b2f0-466c-8774-08f623ccfa8d
It applies to all contacts. installations etc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants