Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some GRSciColl mediators are in suggestion mode even when logged in #553

Open
ManonGros opened this issue Dec 4, 2023 · 9 comments
Open
Labels
bug Something isn't working GRSciColl

Comments

@ManonGros
Copy link
Collaborator

This is an issue reported both by @vijaybarve and @spalp

@spalp mentioned that when she started a suggestion, then cancelled and logged in and click on the edit button again, she wasn't able to save the change. This is a screenshot she sent:

image

When talking to @vijaybarve, I thought the issue was that he was logged out while editing but maybe he had the same issue as Salza.

Vijay and Salza, don't hesitate to comment if you would like to add more details. Thanks!

@ManonGros ManonGros added bug Something isn't working GRSciColl labels Dec 4, 2023
@MortenHofft
Copy link
Member

MortenHofft commented Dec 4, 2023

It would be helpful with more context. What are the roles/usernames of the users. what entities are they trying to edit. Is it always an issue or does it require a special list of actions to trigger?

@MortenHofft
Copy link
Member

I'm guessing that it is spalpurina and

must be this collection https://registry.gbif.org/collection/e2c01c12-4e38-42bd-8c5f-e53c1bc66b74 ?
I cannot see the full uuid. And it has a different description, but the uuid ends in the same chars and the names are the same.

@MortenHofft
Copy link
Member

MortenHofft commented Dec 4, 2023

I see it was last edited 5 hours ago by that user. So what did she need to do to fix it? i cannot reproduce it. Can you or the user?

From above I have no idea I'm afraid. A caching issue on the authentication endpoint perhaps?

@ManonGros
Copy link
Collaborator Author

Both Salza and Vijay are GRSciColl Mediators. They both tried to edit entries that belong to countries within their scope. Instead of being able to edit the entries directly, a suggestion was logged and sent.
Then both of them had to go and apply to suggestions. Like this one: https://registry.gbif.org/collection/e2c01c12-4e38-42bd-8c5f-e53c1bc66b74?suggestionId=1461

I myself haven't encountered the issue.

@spalp
Copy link

spalp commented Dec 5, 2023

From above I have no idea I'm afraid. A caching issue on the authentication endpoint perhaps?

Does this help? Working on the same entry on another machine: https://registry.gbif.org/collection/e2c01c12-4e38-42bd-8c5f-e53c1bc66b74, when I repeated the same steps (i.e. started a suggestion, then cancelled and logged in and click on the edit button again), I was able to save succefully the changes.

@MortenHofft
Copy link
Member

thank you. I will try that

@MortenHofft
Copy link
Member

Oh, rereading that I see that it works in above example. I'm more interested in a repeatable example where it fails.

The cache headers look right. So probably not a caching issue.
I created a user with the same rights, and cannot reproduce any errors.
It makes it difficult to fix.

@spalp if you can, it would be great with a reproducible error example

@vijaybarve
Copy link

I guess the issue is with timeout. I guess, if I take more time to make all the edits it takes me to suggest, but if I submit after every one or two edits, it lets me do it.

@MortenHofft
Copy link
Member

That is useful information and a likely cause @vijaybarve - thanks

The API signs you out automatically after x minutes. @marcos-lg you know the logic of this. The UI tries to compensate for this by signing in on every authenticated request. But if the UI is left unused (or you fill a form for 30 minutes), then there is no API interaction and hence the token isn't renewed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working GRSciColl
Projects
None yet
Development

No branches or pull requests

4 participants