Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] rgbgfx -r should encode the reverse image appropriately #1251

Open
Rangi42 opened this issue Nov 23, 2023 · 2 comments
Open
Labels
enhancement Typically new features; lesser priority than bugs rgbgfx This affects RGBGFX

Comments

@Rangi42
Copy link
Contributor

Rangi42 commented Nov 23, 2023

Currently rgbgfx -r generates all its output images as 8-bit RGBA encoded. I would like if it tried to match the expected encoding of the original input image.

So, if there's no palette, it would output 2-bit grayscale (or 1-bit with -d 1). If there is a palette, it would be embedded in the output PNG as an indexed colormap. Also, there shouldn't be an alpha channel.

This would give smaller output filesizes. Also, it would be more likely to work with people's bespoke build processes (e.g. if they need grayscale or indexed input images, like pret does).

@Rangi42 Rangi42 added enhancement Typically new features; lesser priority than bugs rgbgfx This affects RGBGFX labels Nov 23, 2023
@pinobatch
Copy link
Member

Would rgbgfx -r -c embedded trigger indexed output mode?

@Rangi42
Copy link
Contributor Author

Rangi42 commented Nov 23, 2023

No, that would warn about no longer having the palette information anywhere, and output grayscale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Typically new features; lesser priority than bugs rgbgfx This affects RGBGFX
Projects
None yet
Development

No branches or pull requests

2 participants