Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor gpu_lidar_bridge demo #636

Open
wants to merge 3 commits into
base: ros2
Choose a base branch
from
Open

Refactor gpu_lidar_bridge demo #636

wants to merge 3 commits into from
+31 −66

Conversation

caguero
Copy link
Contributor

@caguero caguero commented Nov 6, 2024

Refactors the gpu_lidar_bridge demo leveraging the latest improvements in ros_gz.

  • I replaced the previous launch file from Python to XML.
  • I didn't tackle the options using ros_gz_point_cloud for now.

Summary

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@caguero
Refactor gpu_lidar_bridge demo
335407c 
Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
@caguero
Merge branch 'ros2' into caguero/gpu_lidar_demo_v2
76aae13
@caguero
Tweak
09ea110 
Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
@caguero caguero marked this pull request as ready for review November 22, 2024 20:41
ahcorde
ahcorde requested changes Nov 25, 2024
View reviewed changes
Copy link
Collaborator

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

similar comment #634

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahcorde ahcorde ahcorde requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
Core development
Status: In review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@caguero @ahcorde