Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faster multitrait simulations #151

Open
gaynorr opened this issue Aug 14, 2023 · 0 comments
Open

Faster multitrait simulations #151

gaynorr opened this issue Aug 14, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@gaynorr
Copy link
Owner

gaynorr commented Aug 14, 2023

Is your feature request related to a problem? Please describe.
AlphaSimR's performance slows down as more traits are added due to QTL genotypes being pulled for each trait separately before calculating genetic values.

Describe the solution you'd like
Pull genotypes for all QTLs first before proceeding to calculation of genetic values. This will reduce computational costs associated with pulling genotypes multiple times with perhaps a small penalty to memory usage. This could be accomplished using an active QTL list in SimParam that tracks all QTL and relative positions (positions within all QTL) for each trait.

Describe alternatives you've considered
Keep track of pleiotropic traits added by a single call to addTrait_ so that their QTL are pulled together. This could increase performance further, but adds complexity due to needing to track when traits are removed or modified.

Pull all genotypes first. This is easier to code because it avoids the need for an active QTL list, but increases memory usage further. It would effectively revert AlphaSimR back to byte storage.

@gaynorr gaynorr added the enhancement New feature or request label Aug 14, 2023
@gaynorr gaynorr self-assigned this Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant