diff --git a/docs/usage/registry-cache/configuration.md b/docs/usage/registry-cache/configuration.md index 47bbe431..45137919 100644 --- a/docs/usage/registry-cache/configuration.md +++ b/docs/usage/registry-cache/configuration.md @@ -96,14 +96,11 @@ The `providerConfig.caches[].secretReferenceName` is the name of the reference f > [!NOTE] > It is only possible to provide one set of credentials for one private upstream registry. -The `providerConfig.caches[].proxy.httpProxy` field contains settings for a proxy which is used by the registry cache. -The registry-cache extension sets this value as `HTTP_PROXY` ENV in the StatefulSet. +The `providerConfig.caches[].proxy.httpProxy` field represents the proxy server for HTTP connections which is used by the registry cache. It must include an `https://` or `http://` scheme. -The `providerConfig.caches[].proxy.httpsProxy` field contains settings for a proxy which is used by the registry cache. -The registry-cache extension sets this value as `HTTPS_PROXY` ENV in the StatefulSet. +The `providerConfig.caches[].proxy.httpsProxy` field represents the proxy server for HTTPS connections which is used by the registry cache. It must include an `https://` or `http://` scheme. -The `providerConfig.caches[].proxy.noProxy` field contains settings for a proxy which is used by the registry cache. -The registry-cache extension sets this value as `NO_PROXY` ENV in the StatefulSet. +The `providerConfig.caches[].proxy.noProxy` field can be set to a comma separated list of IPs which should not connect over the specified proxy server. It can be only set of `httpProxy` and/or `httpsProxy` is set. ## Garbage Collection diff --git a/pkg/apis/registry/types.go b/pkg/apis/registry/types.go index 5a285afa..968d9a1d 100644 --- a/pkg/apis/registry/types.go +++ b/pkg/apis/registry/types.go @@ -62,11 +62,11 @@ type GarbageCollection struct { // Proxy contains settings for a proxy used in the registry cache. type Proxy struct { - // HTTPProxy is used as HTTP_PROXY env in the StatefulSet. + // HTTPProxy field represents the proxy server for HTTP connections which is used by the registry cache. HTTPProxy *string - // HTTPSProxy is used as HTTPS_PROXY env in the StatefulSet. + // HTTPSProxy field represents the proxy server for HTTPS connections which is used by the registry cache. HTTPSProxy *string - // NoProxy is used as NO_PROXY env in the StatefulSet. + // NoProxy field can be set to a comma separated list of IPs which should not connect over the specified proxy server. NoProxy *string } diff --git a/pkg/apis/registry/v1alpha3/types.go b/pkg/apis/registry/v1alpha3/types.go index 6fd49761..a76a3e67 100644 --- a/pkg/apis/registry/v1alpha3/types.go +++ b/pkg/apis/registry/v1alpha3/types.go @@ -71,15 +71,15 @@ type GarbageCollection struct { // Proxy contains settings for a proxy used in the registry cache. type Proxy struct { - // HTTPProxy is used as HTTP_PROXY env in the StatefulSet. + // HTTPProxy field represents the proxy server for HTTP connections which is used by the registry cache. // +optional - HTTPProxy *string `json:"httpProxy"` - // HTTPSProxy is used as HTTPS_PROXY env in the StatefulSet. + HTTPProxy *string `json:"httpProxy,omitempty"` + // HTTPSProxy field represents the proxy server for HTTPS connections which is used by the registry cache. // +optional - HTTPSProxy *string `json:"httpsProxy"` - // NoProxy is used as NO_PROXY env in the StatefulSet. + HTTPSProxy *string `json:"httpsProxy,omitempty"` + // NoProxy field can be set to a comma separated list of IPs which should not connect over the specified proxy server. // +optional - NoProxy *string `json:"noProxy"` + NoProxy *string `json:"noProxy,omitempty"` } var (