Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closing the ReadinessProbe discussion with GET call using --consistency=linearizable #13

Merged
merged 1 commit into from
Aug 16, 2023
Merged

Closing the ReadinessProbe discussion with GET call using --consistency=linearizable #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/concepts/bootstrap.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ Initiliasation loop exits only when the status returned from `etcd-backup-sideca

Start phase mainly comprises of two steps:

1. Set up a readiness probe at `/readyz` where anyone can query to verify if the etcd application is running.
1. Set up a readiness probe at `/readyz` where anyone can query to verify if the etcd application(single node cluster or multi-node cluster) is ready to accept client traffic.

2. Start an embedded etcd using the fetched etcd configuration.

Expand Down
2 changes: 1 addition & 1 deletion internal/app/readycheck.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ func (a *Application) queryAndUpdateEtcdReadiness() {
func (a *Application) isEtcdReady() bool {
etcdConnCtx, cancelFunc := context.WithTimeout(a.ctx, etcdGetTimeout)
defer cancelFunc()
_, err := a.etcdClient.Get(etcdConnCtx, "foo" /*, clientv3.WithSerializable()*/)
_, err := a.etcdClient.Get(etcdConnCtx, "foo")
if err != nil {
a.logger.Error("failed to retrieve from etcd db", zap.Error(err))
}
Expand Down