Skip to content

Commit

Permalink
Closing the ReadinessProbe discussion with GET call using --consisten…
Browse files Browse the repository at this point in the history
…cy=linearizable. (#13)
  • Loading branch information
ishan16696 authored Aug 16, 2023
1 parent b79bf9f commit b7c30d5
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion docs/concepts/bootstrap.md
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ Initiliasation loop exits only when the status returned from `etcd-backup-sideca

Start phase mainly comprises of two steps:

1. Set up a readiness probe at `/readyz` where anyone can query to verify if the etcd application is running.
1. Set up a readiness probe at `/readyz` where anyone can query to verify if the etcd application(single node cluster or multi-node cluster) is ready to accept client traffic.

2. Start an embedded etcd using the fetched etcd configuration.

Expand Down
2 changes: 1 addition & 1 deletion internal/app/readycheck.go
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ func (a *Application) queryAndUpdateEtcdReadiness() {
func (a *Application) isEtcdReady() bool {
etcdConnCtx, cancelFunc := context.WithTimeout(a.ctx, etcdGetTimeout)
defer cancelFunc()
_, err := a.etcdClient.Get(etcdConnCtx, "foo" /*, clientv3.WithSerializable()*/)
_, err := a.etcdClient.Get(etcdConnCtx, "foo")
if err != nil {
a.logger.Error("failed to retrieve from etcd db", zap.Error(err))
}
Expand Down

0 comments on commit b7c30d5

Please sign in to comment.