-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Local
provider for e2e tests
#668
Add support for Local
provider for e2e tests
#668
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good to me
Thanks @shreyas-s-rao for adding local provider support to E2E test
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @shreyas-s-rao!
Looks good, just one question, otherwise /lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
How to categorize this PR?
/area testing quality
/kind test
What this PR does / why we need it:
Add support for
Local
provider for e2e tests, along with other minor fixes/cleanups.Which issue(s) this PR fixes:
Fixes #667
Special notes for your reviewer:
Local
provider backup buckets are created by mounting/etc
hostPath onto the infra job in order to create./gardener/local-backupbuckets/<container-name>
directory and to delete it once the tests are completed. Skaffold + kustomize is used for this, similar to infra jobs of other providers like aws, azure and gcp.v1
snapshots were being purged instead ofv2
snapshots), due to which some tests were flaky, especially creation of 3-node etcd cluster, since backups possibly already existing in the bucket from a previous test spec. This has now been fixed, as well as enhanced forLocal
provider via apurge-local-snapstore
job that runs before each test spec when usingLocal
provider.etcd-main
in many tests have been replaced byetcd-test
.k8s.io/api/core/v1
package ascorev1
andv1
intest/e2e/utils.go
has been rectified.deploy-via-kustomize
inMakefile
has been fixed.Local
provider for e2e tests; minor edits in docs too.This PR can be tested by running:
Release note: