Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix local provider #412

Merged
merged 2 commits into from
Aug 30, 2022
Merged

Fix local provider #412

merged 2 commits into from
Aug 30, 2022

Conversation

timuthy
Copy link
Member

@timuthy timuthy commented Aug 18, 2022

How to categorize this PR?

/area control-plane
/kind bug

What this PR does / why we need it:
This PR fixes the hostPath configuration for the Local provider as explained in the linked issue. It also fixes some potential nil pointer dereferences along the way.

Which issue(s) this PR fixes:
Fixes #407

Release note:

An issue has been fixed that caused Etcd-Druid to not consider the `hostPath` configuration in the referenced backup secret `etcd.spec.backup.store.secretRef`.

@timuthy timuthy requested a review from a team as a code owner August 18, 2022 15:27
@gardener-robot gardener-robot added area/control-plane Control plane related kind/bug Bug needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Aug 18, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 18, 2022
@timuthy timuthy changed the title Fix.local provider Fix local provider Aug 18, 2022
@timuthy
Copy link
Member Author

timuthy commented Aug 23, 2022

@abdasgupta kindly asking you to take a look as you are already familiar with the component concept.

abdasgupta
abdasgupta approved these changes Aug 29, 2022
View reviewed changes
Copy link
Contributor

@abdasgupta abdasgupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR Tim. LGTM

@timuthy timuthy merged commit 7b6b66c into gardener:master Aug 30, 2022
@timuthy timuthy deleted the fix.local-provider branch August 30, 2022 06:33
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abdasgupta abdasgupta abdasgupta approved these changes

Assignees
No one assigned
Labels
area/control-plane Control plane related kind/bug Bug needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Hostpath not configureable via backup secret
4 participants
@timuthy @abdasgupta @gardener-robot-ci-3 @gardener-robot