Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cleanup] Use consistent images for e2e test utils #670

Open
shreyas-s-rao opened this issue Aug 16, 2023 · 2 comments
Open

[Cleanup] Use consistent images for e2e test utils #670

shreyas-s-rao opened this issue Aug 16, 2023 · 2 comments
Assignees
Labels
kind/enhancement Enhancement, improvement, extension
Milestone

Comments

@shreyas-s-rao
Copy link
Contributor

Feature (What you would like to be added):
Use consistent images for e2e test utils.

Motivation (Why is this needed?):
Druid e2e tests use multiple helper jobs that run certain short-lived commands and exit afterwards. These job pods are defined to use different, inconsistent images for their containers, as can be seen here, here and here.

Approach/Hint to the implement solution (optional):
Infra-job pod uses ubuntu images for installing cloud provider CLIs for creating/deleting backup buckets. We can possibly use the same image in e2e test utils as well, since the image would have already been pulled onto the KinD cluster node before starting test execution, and resource consumption by these utility jobs would be insignificant since they are short-lived in nature.

/cc @seshachalam-yv @aaronfern

@shreyas-s-rao shreyas-s-rao added the kind/enhancement Enhancement, improvement, extension label Aug 16, 2023
@shreyas-s-rao shreyas-s-rao added this to the v0.20.0 milestone Aug 16, 2023
@shreyas-s-rao shreyas-s-rao modified the milestones: v0.20.0, v0.21.0 Sep 29, 2023
@shreyas-s-rao shreyas-s-rao modified the milestones: v0.21.0, v0.22 Nov 20, 2023
@shreyas-s-rao shreyas-s-rao modified the milestones: v0.22.0, v0.23.0 Jan 9, 2024
@shreyas-s-rao
Copy link
Contributor Author

/assign @anveshreddy18

@unmarshall
Copy link
Contributor

unmarshall commented Nov 27, 2024

As part of #782 we are going to make changes in the way e2e tests are setup. Please do not work on this issue.

@gardener-robot gardener-robot added the reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies label Nov 27, 2024
@unmarshall unmarshall removed the reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies label Nov 27, 2024
@ishan16696 ishan16696 modified the milestones: v0.24.0, v0.26.0 Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Enhancement, improvement, extension
Projects
None yet
Development

No branches or pull requests

6 participants