Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement "component" concept for all the K8s resources #278

Closed
8 tasks done
abdasgupta opened this issue Dec 21, 2021 · 6 comments
Closed
8 tasks done

Implement "component" concept for all the K8s resources #278

abdasgupta opened this issue Dec 21, 2021 · 6 comments
Assignees
@seshachalam-yv
Labels
kind/enhancement Enhancement, improvement, extension lifecycle/stale Nobody worked on this for 6 months (will further age) priority/3 Priority (lower number equals higher priority) status/closed Issue is closed (either delivered or triaged)
Milestone
2023-Q2

Comments

@abdasgupta
Copy link
Contributor

abdasgupta commented Dec 21, 2021 •
edited by seshachalam-yv
Loading

Feature (What you would like to be added):
Implement "component" concept for all the K8s resources to replace the chart that we use in Druid and instead build the K8s resources within the code

Motivation (Why is this needed?):
To achieve a better test-ability and more control how the client is used to reconcile the objects (e.g. used verb UPDATE vs PATCH) or how merging objects will be implemented. The same approach was taken in gardener/gardener.

Please see this comment for more information.

Approach/Hint to the implement solution (optional):
Please follow this PR for the idea to implement.
@abdasgupta abdasgupta added the kind/enhancement Enhancement, improvement, extension label Dec 21, 2021
@abdasgupta
Copy link
Contributor Author

cc @ashwani2k @aaronfern @ishan16696 @timuthy

This was referenced Dec 22, 2021
Merged
Closed
@abdasgupta abdasgupta mentioned this issue Jul 4, 2022
Merged
@gardener-robot gardener-robot added the lifecycle/stale Nobody worked on this for 6 months (will further age) label Jul 25, 2022
@timuthy timuthy mentioned this issue Jul 28, 2022
Open
@abdasgupta abdasgupta changed the title Implement "component" concept for all th K8s resources Implement "component" concept for all the K8s resources Jan 5, 2023
@abdasgupta abdasgupta added the priority/3 Priority (lower number equals higher priority) label Jan 6, 2023
@abdasgupta
Copy link
Contributor Author

We have two of the k8s resources to be left to be converted with golang code. We will pick them up when we are less overloaded.

@shreyas-s-rao
Copy link
Contributor

Added another task to the original list in issue description: Job (for EtcdCopyBackupsTask Controller)

@seshachalam-yv
Copy link
Contributor

/assign

@ashwani2k ashwani2k added this to the 2023-Q2 milestone Feb 21, 2023
@seshachalam-yv
Copy link
Contributor

seshachalam-yv commented Feb 28, 2023 •
edited
Loading

Raised PRs for following components,

@aaronfern aaronfern mentioned this issue Mar 20, 2023
Merged
@aaronfern aaronfern linked a pull request Mar 20, 2023 that will close this issue
Refactor Role Helm charts into component #538
Merged
@aaronfern aaronfern removed a link to a pull request Mar 20, 2023
Refactor Role Helm charts into component #538
Merged
@shreyas-s-rao
Copy link
Contributor

/close as #559 is merged

@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@seshachalam-yv seshachalam-yv

Labels
kind/enhancement Enhancement, improvement, extension lifecycle/stale Nobody worked on this for 6 months (will further age) priority/3 Priority (lower number equals higher priority) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
2023-Q2
Development

No branches or pull requests
5 participants
@ashwani2k @abdasgupta @shreyas-s-rao @gardener-robot @seshachalam-yv