Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Divide the Druid controllers into Reconciler and Actuator #259

Open
abdasgupta opened this issue Nov 16, 2021 · 2 comments
Open
Labels
kind/enhancement Enhancement, improvement, extension lifecycle/rotten Nobody worked on this for 12 months (final aging stage) priority/4 Priority (lower number equals higher priority)

Comments

@abdasgupta
Copy link
Contributor

Feature (What you would like to be added):
To improve the readability of the druid controllers, we need to divide each controllers in two parts - reconciler and Actuator.

  • The "reconciler" is responsible for reading the object that is being reconciled, managing finalizers, annotations, and status updates, and making the distinction between reconciling a creation / update (what we call "reconcile") and reconciling a deletion (what we call "delete"). Reconciliation logic is usually similar / generic and so often the same reconciler can be used with different actuators - but even if this is not the case, the distinction is still useful.

  • The "actuator" is responsible for the actual reconciliation / deletion logic and returning an appropriately updated status (but not actually updating it).

For more details, follow the conversation : #235 (comment)
Motivation (Why is this needed?):

Approach/Hint to the implement solution (optional):

@abdasgupta abdasgupta added the kind/enhancement Enhancement, improvement, extension label Nov 16, 2021
@abdasgupta
Copy link
Contributor Author

cc @stoyanr

@gardener-robot gardener-robot added the lifecycle/stale Nobody worked on this for 6 months (will further age) label May 16, 2022
@gardener-robot gardener-robot added lifecycle/rotten Nobody worked on this for 12 months (final aging stage) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Nov 12, 2022
@unmarshall
Copy link
Contributor

see #235 (comment)

@abdasgupta abdasgupta added the priority/4 Priority (lower number equals higher priority) label Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Enhancement, improvement, extension lifecycle/rotten Nobody worked on this for 12 months (final aging stage) priority/4 Priority (lower number equals higher priority)
Projects
None yet
Development

No branches or pull requests

3 participants