Merge pull request #190 from majst01/enable-profiling

Enable profiling of etcd-backup-restore-sidecar
gardener · Jun 16, 2021 · 0aa9de3 · 0aa9de3
2 parents f02ff02 + 2ae4649
commit 0aa9de3
Show file tree

Hide file tree

Showing 6 changed files with 22 additions and 1 deletion.
diff --git a/api/v1alpha1/etcd_types.go b/api/v1alpha1/etcd_types.go
@@ -138,6 +138,9 @@ type BackupSpec struct {
 	// SnapshotCompression defines the specification for compression of Snapshots.
 	// +optional
 	SnapshotCompression *CompressionSpec `json:"compression,omitempty"`
+	// EnableProfiling defines if profiling should be enabled for the etcd-backup-restore-sidecar
+	// +optional
+	EnableProfiling *bool `json:"enableProfiling,omitempty"`
 }
 
 // EtcdConfig defines parameters associated etcd deployed

diff --git a/charts/etcd/templates/etcd-statefulset.yaml b/charts/etcd/templates/etcd-statefulset.yaml
@@ -135,6 +135,9 @@ spec:
 {{- if .Values.backup.etcdQuotaBytes }}
         - --embedded-etcd-quota-bytes={{ int $.Values.backup.etcdQuotaBytes }}
 {{- end }}
+{{- if .Values.backup.enableProfiling }}
+        - --enable-profiling={{ .Values.backup.enableProfiling }}
+{{- end }}
 {{- if .Values.etcd.enableTLS }}
         - --cert=/var/etcd/ssl/client/tls.crt
         - --key=/var/etcd/ssl/client/tls.key

diff --git a/charts/etcd/values.yaml b/charts/etcd/values.yaml
@@ -36,6 +36,7 @@ backup:
   snapstoreTempDir: "/var/etcd/data/temp"
   etcdConnectionTimeout: 5m
   etcdQuotaBytes: 8Gi
+  enableProfiling: false
   garbageCollectionPolicy: LimitBased
   maxBackups: 7
   resources:

diff --git a/config/crd/bases/druid.gardener.cloud_etcds.yaml b/config/crd/bases/druid.gardener.cloud_etcds.yaml
@@ -4,7 +4,7 @@ apiVersion: apiextensions.k8s.io/v1
 kind: CustomResourceDefinition
 metadata:
   annotations:
-    controller-gen.kubebuilder.io/version: v0.4.1
+    controller-gen.kubebuilder.io/version: v0.5.0
   creationTimestamp: null
   name: etcds.druid.gardener.cloud
 spec:
@@ -78,6 +78,10 @@ spec:
                     description: DeltaSnapshotPeriod defines the period after which
                       delta snapshots will be taken
                     type: string
+                  enableProfiling:
+                    description: EnableProfiling defines if profiling should be enabled
+                      for the etcd-backup-restore-sidecar
+                    type: boolean
                   fullSnapshotSchedule:
                     description: FullSnapshotSchedule defines the cron standard schedule
                       for full snapshots.

diff --git a/controllers/etcd_controller.go b/controllers/etcd_controller.go
@@ -900,12 +900,19 @@ func (r *EtcdReconciler) getMapFromEtcd(etcd *druidv1alpha1.Etcd) (map[string]in
 		deltaSnapshotMemoryLimit = etcd.Spec.Backup.DeltaSnapshotMemoryLimit.Value()
 	}
 
+	var enableProfiling = false
+	if etcd.Spec.Backup.EnableProfiling != nil {
+		enableProfiling = *etcd.Spec.Backup.EnableProfiling
+
+	}
+
 	backupValues := map[string]interface{}{
 		"pullPolicy":               corev1.PullIfNotPresent,
 		"etcdQuotaBytes":           quota,
 		"etcdConnectionTimeout":    "5m",
 		"snapstoreTempDir":         "/var/etcd/data/temp",
 		"deltaSnapshotMemoryLimit": deltaSnapshotMemoryLimit,
+		"enableProfiling":          enableProfiling,
 	}
 
 	if etcd.Spec.Backup.Resources != nil {

diff --git a/vendor/github.com/gardener/etcd-druid/api/v1alpha1/etcd_types.go b/vendor/github.com/gardener/etcd-druid/api/v1alpha1/etcd_types.go