Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to read JSON credential files present in a directory passed through the <PROVIDER>_APPLICATION_CREDENTIALS environment variable #730

Merged
merged 3 commits into from
May 17, 2024

Commits on Apr 28, 2024

  1. Add support to read JSON credential files present in a directory pass…

    …ed through the `${PROVIDER}_APPLICATION_CREDENTIALS` environment variable.
    
    * Add support to read JSON credential files present in a directory which
      is passed through the `${PROVIDER}_APPLICATION_CREDENTIALS` environment
      variable for all (applicable) providers.
    
    * Remove examples which suggest that cloud provider credentials can be
      passed through a JSON file since this will be deprecated in future releases.
    
    * Improve error handling in various `SnapStore` related files for each
      cloud provider.
    
    * Updated docs to discourage usage of JSON files to pass credentials.
    
    * Housekeeping in `pkg/server/backuprestoreserver.go`.
      Changed an unused named function parameter to `_`, and removed a
      tautological if condition.
    renormalize committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    b76f0d8 View commit details
    Browse the repository at this point in the history

Commits on May 5, 2024

  1. Address review comments by @ishan16696

    * Remove JSON method from the various ways to pass credentials section.
    
    * Remove a confusing line about passing credentials as individual files.
    renormalize committed May 5, 2024
    Configuration menu
    Copy the full SHA
    7300b60 View commit details
    Browse the repository at this point in the history

Commits on May 13, 2024

  1. Addressing review comments by @ishan16696 2

    * Fix comments documenting functions
    
    * Enhance `docs/deployment/getting_started.md`
    
    * Unnecessary argument for error string creation in `pkg/snapstore/utils.go` removed
    renormalize committed May 13, 2024
    Configuration menu
    Copy the full SHA
    81620c7 View commit details
    Browse the repository at this point in the history