Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Drop support of passing credentials to etcd-backup-restore through a JSON file #741

Open
renormalize opened this issue May 16, 2024 · 0 comments
Assignees
Labels
kind/enhancement Enhancement, improvement, extension
Milestone

Comments

@renormalize
Copy link
Member

renormalize commented May 16, 2024

Enhancement (What you would like to be added):

Currently there are two ways of passing credentials to etcd-backup-restore, which are:

  • As individual fields in a Secret (consumed as individual files for each field in a directory, by etcd-backup-restore).
  • As a JSON data field in a Secret (consumed as a JSON file, by etcd-backup-restore).

The intent is to drop support to pass credentials through the JSON format, and only support individual fields in a Secret (consumed as individual files in a directory by etcd-backupr-restore).

Motivation (Why is this needed?):

There was confusion in the community regarding how credentials are passed to etcd-backup-restore, and it was decided to only allow one way of passing credentials, as discussed in #729 (comment).

Approach/Hint to the implement solution (optional):

Remove all code that enables the passing of credentials as a JSON file in etcd-backup-restore.

@renormalize renormalize added the kind/enhancement Enhancement, improvement, extension label May 16, 2024
@renormalize renormalize added this to the v0.31.0 milestone May 16, 2024
@renormalize renormalize self-assigned this May 16, 2024
@renormalize renormalize changed the title [Enhancement] Disable multiple ways to pass credentials to etcd-backup-restore [Enhancement] Drop support of passing credentials to etcd-backup-restore through a JSON file May 16, 2024
@ishan16696 ishan16696 modified the milestones: v0.31.0, v0.33.0 Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Enhancement, improvement, extension
Projects
None yet
Development

No branches or pull requests

2 participants