fix a image loading issue when src attrubute is empty

ganlanyuan · Dec 17, 2018 · ee469fb · ee469fb
1 parent 3f167ed
commit ee469fb
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 17 deletions.
diff --git a/dist/min/tiny-slider.js b/dist/min/tiny-slider.js
diff --git a/dist/sourcemaps/tiny-slider.js.map b/dist/sourcemaps/tiny-slider.js.map
diff --git a/dist/tiny-slider.js b/dist/tiny-slider.js
@@ -1191,14 +1191,11 @@ var tns = function(options) {
       forEach(imgs, function(img) {
         var src = img.src;
 
-        if (src.indexOf('data:image') < 0) {
+        if (src && src.indexOf('data:image') < 0) {
           addEvents(img, imgEvents);
           img.src = '';
           img.src = src;
           addClass(img, 'loading');
-
-          // check image cache
-          if (img.complete) { img.naturalWidth !== 0 ? imgLoaded(img) : imgFailed(img); }
         } else if (!lazyload) {
           imgLoaded(img);
         }
@@ -2242,7 +2239,6 @@ var tns = function(options) {
   }
 
   function imgFailed (img) {
-    console.log(img, img.src);
     addClass(img, 'failed');
     imgCompleted(img);
   }

diff --git a/src/tiny-slider.js b/src/tiny-slider.js
@@ -759,14 +759,11 @@ export var tns = function(options) {
       forEach(imgs, function(img) {
         var src = img.src;
 
-        if (src.indexOf('data:image') < 0) {
+        if (src && src.indexOf('data:image') < 0) {
           addEvents(img, imgEvents);
           img.src = '';
           img.src = src;
           addClass(img, 'loading');
-
-          // check image cache
-          if (img.complete) { img.naturalWidth !== 0 ? imgLoaded(img) : imgFailed(img); }
         } else if (!lazyload) {
           imgLoaded(img);
         }
@@ -1810,7 +1807,6 @@ export var tns = function(options) {
   }
 
   function imgFailed (img) {
-    console.log(img, img.src);
     addClass(img, 'failed');
     imgCompleted(img);
   }

diff --git a/src/tiny-slider.module.js b/src/tiny-slider.module.js
@@ -759,14 +759,11 @@ export var tns = function(options) {
       forEach(imgs, function(img) {
         var src = img.src;
 
-        if (src.indexOf('data:image') < 0) {
+        if (src && src.indexOf('data:image') < 0) {
           addEvents(img, imgEvents);
           img.src = '';
           img.src = src;
           addClass(img, 'loading');
-
-          // check image cache
-          if (img.complete) { img.naturalWidth !== 0 ? imgLoaded(img) : imgFailed(img); }
         } else if (!lazyload) {
           imgLoaded(img);
         }
@@ -1810,7 +1807,6 @@ export var tns = function(options) {
   }
 
   function imgFailed (img) {
-    console.log(img, img.src);
     addClass(img, 'failed');
     imgCompleted(img);
   }