review: Replaced secret ID with secret name

Signed-off-by: Eamonn Mansour <47121388+eamansour@users.noreply.github.com>
galasa-dev · Oct 28, 2024 · 98b5eae · 98b5eae
1 parent 97549b3
commit 98b5eae
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/...amework.api.common/src/main/java/dev/galasa/framework/api/common/ServletErrorMessage.java b/...amework.api.common/src/main/java/dev/galasa/framework/api/common/ServletErrorMessage.java
@@ -96,10 +96,10 @@ public enum ServletErrorMessage {
     GAL5073_UNSUPPORTED_GALASA_SECRET_ENCODING        (5073, "E: Unsupported data encoding scheme provided. Supported encoding schemes are: [{0}]. Check that your request payload is correct and try again."),
     GAL5074_UNKNOWN_GALASA_SECRET_TYPE                (5074, "E: Unknown GalasaSecret type provided. Supported GalasaSecret types are: [{0}]. Check that your request payload is correct and try again."),
     GAL5075_ERROR_SECRET_ALREADY_EXISTS               (5075, "E: Error occurred when trying to create a secret with the given name. A secret with the provided name already exists."),
-    GAL5076_ERROR_SECRET_DOES_NOT_EXIST               (5076, "E: Error occurred. A secret with the provided ID does not exist. Check that your provided secret name is correct and try again."),
+    GAL5076_ERROR_SECRET_DOES_NOT_EXIST               (5076, "E: Error occurred. A secret with the provided name does not exist. Check that your provided secret name is correct and try again."),
     GAL5077_FAILED_TO_SET_SECRET                      (5077, "E: Failed to set a secret with the given ID in the credentials store. The credentials store might be experiencing temporary issues. Report the problem to your Galasa Ecosystem owner."),
     GAL5078_FAILED_TO_DELETE_SECRET                   (5078, "E: Failed to delete a secret with the given ID from the credentials store. The credentials store might be experiencing temporary issues. Report the problem to your Galasa Ecosystem owner."),
-    GAL5079_FAILED_TO_GET_SECRET                      (5079, "E: Failed to retrieve the secret with the given ID from the credentials store. A secret with the provided ID does not exist and therefore cannot be updated."),
+    GAL5079_FAILED_TO_GET_SECRET                      (5079, "E: Failed to retrieve the secret with the given ID from the credentials store. A secret with the provided name does not exist and therefore cannot be updated."),
 
     // Auth APIs...
     GAL5051_INVALID_GALASA_TOKEN_PROVIDED             (5051, "E: Invalid GALASA_TOKEN value provided. Please ensure you have set the correct GALASA_TOKEN property for the targeted ecosystem at ''{0}'' and try again."),

diff --git a/...rc/test/java/dev/galasa/framework/api/resources/processors/GalasaSecretProcessorTest.java b/...rc/test/java/dev/galasa/framework/api/resources/processors/GalasaSecretProcessorTest.java
@@ -554,7 +554,7 @@ public void testUpdateSecretThatDoesNotExistThrowsError() throws Exception {
         // Then...
         assertThat(thrown).isNotNull();
         checkErrorStructure(thrown.getMessage(), 5076, "GAL5076E",
-            "A secret with the provided ID does not exist");
+            "A secret with the provided name does not exist");
     }
 
     @Test

diff --git a/...crets/src/test/java/dev/galasa/framework/api/secrets/internal/SecretDetailsRouteTest.java b/...crets/src/test/java/dev/galasa/framework/api/secrets/internal/SecretDetailsRouteTest.java
@@ -200,7 +200,7 @@ public void testDeleteNonExistantSecretReturnsError() throws Exception {
         assertThat(servletResponse.getStatus()).isEqualTo(404);
         assertThat(servletResponse.getContentType()).isEqualTo("application/json");
         checkErrorStructure(outStream.toString(), 5076, "GAL5076E",
-            "Error occurred. A secret with the provided ID does not exist.");
+            "Error occurred. A secret with the provided name does not exist.");
     }
 
     @Test